Design comparison
Solution retrospective
I would focus more on the similarity of the design with good semantics
What challenges did you encounter, and how did you overcome them?This challenge is difficult if you don't know box-shadow
What specific areas of your project would you like help with?In the semantics of my code
Community feedback
- @SantiagoGelvezPosted 2 months ago
It is a great project. There are some things to stay closer to the design.
-
Ensure your max-width of the class hero-container to the design on figma. Also similar to the borders and pading.
-
Use `line-height: 1.5;``in your universal selector to have a separation on the text lines.
With these improvements I hope you project look similar to desgin.
Related to another things like use of BEM, values in rem and use of gap, I really like the way you code.
Marked as helpful0@matiasaltierPosted 2 months ago@SantiagoGelvez Thank you for your review, I really appreciate it. You are right about the line-height and max-width. I will implement it in this project and will take it into account in the following ones
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord