GSD3v08• 190
@GSD3v08
Submitted
Hello , this is my second project, could you tell me if there's something that can be improved or what should I learn for future projects?.
Feel free to leave your comments, any help will be appreciate it.
Thank you.
Hyun Lee
@Sagameister
All comments
- Hyun Lee• 140
@Sagameister
Posted
Looks, fantastic! The only tiny improvement I can see is in the HTML mark up you can make it more accessible like so:
- Consider rewrite <main> to <main class="card"></main> and remove <div class="card">. You also save 2 lines. ;-)
- Consider changing <div class="text-container"> to <article class="text-container">...
By the way, I love the way you used the CSS variables. I need to do more of that.
Cheers. 😃
Marked as helpful
0 - Gabriel Leão• 40
@Gabriel-Leao
Submitted
I only needed help with the view-icon part, the rest I managed to do myself.
Hyun Lee• 140@Sagameister
Posted
Looks awesome, mate! Love your solution for the hero image hover effect!
As for your aligning the icon try:
.card-icons { margin-bottom: 1vh; display: flex; justify-content: space-between; align-items: center ; }
Then inside the .card-icons div, create a new div and place the etherium icon and text inside it. And same with items on the right.
This should help align better. I hope this helps! :-)
Marked as helpful
0 - Rabie Abdullah• 130
@Rabie-Abdullah
Submitted
Hey, could you guys give me your feedback ? Thanks in advice
Hyun Lee• 140@Sagameister
Posted
Great Job! Also, I noticed how you can clean up a little code.
In your CSS for p: remove text-align: center; instead add it to your .qr_text class. This way your h1 and the p are centered within the container.
Cheers! :-)
Marked as helpful
0 - Deepak Saroha• 120
@deepaksaroha
Submitted
Hyun Lee• 140@Sagameister
Posted
Awesome job!! The code looks great!
The only thing that can make you a tiny bit more efficient is adding a class for your main tag in the HTML. For example, <main class="outer">. And the layout could be much better looking using the google font specified in the readme doc.
Cheers.
Marked as helpful
0
