Skip to content
Submitted over 2 years ago

QR-code component

GSD3v08•190
@GSD3v08
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello , this is my second project, could you tell me if there's something that can be improved or what should I learn for future projects?.

Feel free to leave your comments, any help will be appreciate it.

Thank you.

Community feedback

  • Hyun Lee•140
    @SagameisterPosted over 2 years ago

    Looks, fantastic! The only tiny improvement I can see is in the HTML mark up you can make it more accessible like so:

    1. Consider rewrite <main> to <main class="card"></main> and remove <div class="card">. You also save 2 lines. ;-)
    2. Consider changing <div class="text-container"> to <article class="text-container">...

    By the way, I love the way you used the CSS variables. I need to do more of that.

    Cheers. 😃

    Marked as helpful
    0
    GSD3v08•190
    @GSD3v08Posted over 2 years ago

    @Sagameister I changed the lines ,thank you very much for your advice that helps me alot to improve my code.

    0
  • MatiX•360
    @MatiX221Posted over 2 years ago

    Really good. You should have at least one h1 tag. You can change <p class="qr-title">Improve your front-end skills by building projects</p> into <h1 class="qr-title">Improve your front-end skills by building projects</h1> And this accessibility issue will disapear.

    Marked as helpful
    0
    GSD3v08•190
    @GSD3v08Posted over 2 years ago

    @MatiX221 thank you very much for your feedback, I've made the changes as you suggested and 0 issues.

    0
  • Bohdan•130
    @BohdanNikolaychukPosted over 2 years ago

    Looks,incredibly.Never mind about this errors

    0
    GSD3v08•190
    @GSD3v08Posted over 2 years ago

    @BohdanNikolaychuk thank you for your feedback.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord