Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component challenge hub

@Rabie-Abdullah

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey, could you guys give me your feedback ? Thanks in advice

Community feedback

Hyun Lee 140

@Sagameister

Posted

Great Job! Also, I noticed how you can clean up a little code.

In your CSS for p: remove text-align: center; instead add it to your .qr_text class. This way your h1 and the p are centered within the container.

Cheers! :-)

Marked as helpful

0

@Rabie-Abdullah

Posted

@Sagameister Thank you so much

0

@arfarobs

Posted

Hey man. Good job on completing the challenge. I got two bits of feedback for you.

1 - I made this same mistake when I did this challenge. You forgot to add shadow to the box.

2 - If you want to get rid of the accessibility errors in your report. Wrap your content in a <main> tag and add an <h1> tag to it.

Hope it helps.

Marked as helpful

0

@Rabie-Abdullah

Posted

@arfarobs I fixed the issue. Thanks man!

0

@arfarobs

Posted

@Rabie-Abdullah

No worries mate

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord