Priyesh Singh Waldiaā¢ 150
@Priyesh-Singh-Waldia
Submitted
Would like to get some valuable feedback on my code.
RaffayElahi
@RaffayElahi
All comments
- RaffayElahiā¢ 130
@RaffayElahi
Posted
Hey @Priyesh-Singh-Waldia! I viewed your code, it was great. This was the following practice that I would recommend you to follow out:
- Make structured HTML pages. I saw your code, it was randomly containing tags like
asideanddiv class='container'. Although aside tags is used for ads as majority and when you will do the SEO o your website, it will have a great impact on it. I hope you will follow it, Happy coding, Regards.
Marked as helpful
0 - Make structured HTML pages. I saw your code, it was randomly containing tags like
- younasBnHasainarā¢ 40
@younasBnHasainar
Submitted
I did took this challenge for my learning purpose. I could practice layout specifications of css. Firstly I tried to implement using inline block. And then I re-implemented using flexbox when I learnt it. Feedbacks are welcome. :) I will help me to improve
RaffayElahiā¢ 130@RaffayElahi
Posted
Hey @younasBnHasainar! I saw your code, it was great but some practices will greatly help you in your long-term web development journey. Those practices are:-
- I saw that your HTML wasn't structured as you were using randomly
h2andh4tags, try using heading tags according to the importance of heading and heading number. This practice will make your SEO friendly also usesectiontags for covering your whole main content instead ofdiv. These look like small negligible mistakes but these make difference in readibility and access to your code. - Second, you could make the whole
bodyaflex containerin order to center out the main div instead of using out margins. - Try using
ulandlifor listing out things instead of listing out things inptags. Also try to use flex containers as much as possible to make your content aligning out either in row or column or wither centering it or giving out space evenly. Flexbox is really helpful.
Hope these suggestion were helpful. Happing coding and regards.
0 - I saw that your HTML wasn't structured as you were using randomly
- Leonardo Vianaā¢ 30
@leveau10
Submitted
Hey! Should i change anything in my code? If so, which are the best practices?
RaffayElahiā¢ 130@RaffayElahi
Posted
Hey @leveau10! I viewed your code, it was great code. Great work done by you. I noticed the following things:-
- You were using margins to center out
divs. Instead of that you can usejustify-content:center;property to center out your content and also giving out widths to the 'div' to make sure that it doesn't overflow or take extra text. - Also try to use
sectiontag and similar HTML tags to make your code readable which will greatly help you in your further web development journey.
Hope you find these suggestions helpful.
Happy coding and regards.
Marked as helpful
2 - You were using margins to center out
- oishiā¢ 150
@sumyta12
Submitted
Feel free and give me some suggestion š
RaffayElahiā¢ 130@RaffayElahi
Posted
Hey @sumyta12, The website looks phenomenal, I don't know much about the api side but it was great. I would prefer you to use tailwind css for adding and managing responsiveness. However, the website was great. Regards.
Marked as helpful
0 - Harshā¢ 305
@1Mpedence
Submitted
New to HTML, CSS, and JS. Learned for the first time how to use range input and checkbox. It was fun :P. Would appreciate any feedback and advice. ThankYou :D
RaffayElahiā¢ 130@RaffayElahi
Posted
There is a simple error in this website. You should have to update the pageviews as the scrollable slider is being scrolled. It is easy to update and is written in the challenge0
0
