Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR-Code component using raw html and css

@leveau10

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey! Should i change anything in my code? If so, which are the best practices?

Community feedback

@RaffayElahi

Posted

Hey @leveau10! I viewed your code, it was great code. Great work done by you. I noticed the following things:-

  • You were using margins to center out divs. Instead of that you can use justify-content:center; property to center out your content and also giving out widths to the 'div' to make sure that it doesn't overflow or take extra text.
  • Also try to use section tag and similar HTML tags to make your code readable which will greatly help you in your further web development journey.

Hope you find these suggestions helpful.

Happy coding and regards.

Marked as helpful

2

@leveau10

Posted

Thank you for your feedback, @RaffayElahi!

1

@PJIceskull

Posted

Hey @leveau10, overall you did a really great job in recreating the design in your solution. The only thing I think you're missing is the box-shadow under the QR code card. Nonetheless, good job!

1

@mohamed-arab1

Posted

Amazing! Keep going

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord