@randyluongSubmitted 10 days ago
Psalmorg
@PsalmorgAll comments
- @PsalmorgPosted 10 days ago
Join the discord group and wait for feedback before another challenge and following the challenge in other of complexity is good process of development
0 - @randyluongSubmitted 10 days ago@PsalmorgPosted 10 days ago
I don't know why you didn't follow the specified font but i think using it will be good and your work will look great. I think
- you can use grid for the real price and the alternate price to style that or put it in a container and flex the display. That will enable you to style both price
- you should also include the cart image in button and try to give it a little bit of padding and margin to centralize it. -making the width of the each div (for both image and the perfume details) 50% will equalize the width. Great work though
0 - @Kaue-oliveira-hubSubmitted 11 days agoWhat challenges did you encounter, and how did you overcome them?
etc
What specific areas of your project would you like help with?etc
@PsalmorgPosted 11 days agoI think doing the exact thing without any change in design will be of great benefit to you and from there you will know your level. You can now apply what you learn to anything you want to create if you don't want the challenge design but a dynamic of yours. There is no how you can get feedback if people don't understand what you are trying to do. It like listening to language you don't understand, there won't be interaction.
0 - @yosefshawahSubmitted 13 days agoWhat specific areas of your project would you like help with?
mobile view, header text not working good on smaller screens, fonts.
@PsalmorgPosted 13 days agoThis is good but it can better and i think:
- physically i think your font-size is too big and it need to be reduced;
- the right tag for each link is anchor tag since we know they navigate to other web and styling them block will remove the; inline property the tag possess and a little bit of top and bottom padding will make it look nice;
- the <p> can be use for instead of <span>. I learn recently that there is <address> tag itself that can do that since it contain address;
- reducing the width be good also.
Marked as helpful1 - @Tainicknack0505Submitted 13 days agoWhat are you most proud of, and what would you do differently next time?
I'm most proud of how the design and layout turned out to be responsive and visually appealing. The use of fonts, colors, and the overall structure really give the profile a professional look.
What challenges did you encounter, and how did you overcome them?One of the challenges was ensuring that the layout remained consistent across different screen sizes. To overcome this, I used media queries to adjust the styles for smaller screens. Additionally, getting the font sizes and padding just right required some trial and error, but it was rewarding to see it all come together.
What specific areas of your project would you like help with?-
Accessibility: Are there any improvements I can make to enhance the accessibility of the profile?
-
CSS Best Practices: Any suggestions on refining my CSS for better maintainability and readability would be appreciated.
-
Responsive Design: I'd love to hear if there are more efficient ways to make the design responsive across different devices.
@PsalmorgPosted 13 days agoThis looks good but i think instead of nesting your anchor tag in <p>, styling it block will do the <p> work you are using it for. And the right tag for the text below is footer.
0 -
- @OHAI7546Submitted 14 days agoWhat are you most proud of, and what would you do differently next time?
i was proud of the improvement on my css styling compared to the previous projects
What challenges did you encounter, and how did you overcome them?the css part gave me a little bit of challenge, i had to get clue from chatgpt
What specific areas of your project would you like help with?css
@PsalmorgPosted 13 days ago- Try to put all your code in a container
- Use an heading element for the learning and style it display: inline; after that, you can give it a padding and the background color
- You can create a footer in the main for the blogger image and name. display: flex; will make them come inline and a little bit of margin will create a space.
- border-radius for the blog card image and the main that act as the container
- You can now create a box-shadow for the main to achieve the shadow effect Good but try to check others solution and go to discord and check similar project that have a feedback already. I was told told this morning not to feel shy. There, there are more better way than mine with great people doing things in simpler way with good semantics
0 - @miaxocSubmitted 14 days ago@PsalmorgPosted 13 days ago
Styling the tag you use on 'learning' display: inline; will remove it default block property and you just have to give a little bit of padding and finish it with the border-radius. This is good but you can do more
Marked as helpful0 - @van3030Submitted 14 days agoWhat are you most proud of, and what would you do differently next time?
I'm so proud that I finish the challenge much faster than the first challenge and also I think my code is much cleaner than the first. Next time I'm going to try a different design.
What challenges did you encounter, and how did you overcome them?I think the most challenging for me of this project is the color of the button, because I think the color that provided by frontendmentor is not complete.
What specific areas of your project would you like help with?I'm looking for help in brainstorming alternative approaches and designs for this project.
@PsalmorgPosted 13 days agoI don't know why you change almost everything but it's good.
- The button is not working let alone of hovering, that need to be work on.
- The container as well as the button need the border-radius
- Remove the bottom text from the container.
- Reduce the width of the container so that the space at the left and right won't be much.
Marked as helpful0 - @ReactLlordSubmitted 14 days ago@PsalmorgPosted 13 days ago
- On Mobile view, top left and right of the image need a border-radius and the product name need a color
- I don't think there is need to specify the image height and it decreasing as screen size decrease shows you use %
- You also try to make you price and alt price display: inline; just my thought for them to be side-by-side.
- Also reduce the spacing between the cart button and the price (you did a great work on that thou, my cart is not perfect as yours).
0 - @zekeer21Submitted 14 days agoWhat are you most proud of, and what would you do differently next time?
It's a bit of a challenge since the colors are not given and I have to experiment and test every possible colors. But it's worth the try.
What challenges did you encounter, and how did you overcome them?Picking the right colors and the right sizes.
@PsalmorgPosted 14 days agoI think using anchor tag will make the code semantic than the you customizing the list since we take that as link button. Just my view thou. Great work
Marked as helpful0 - @will3343Submitted 14 days agoWhat are you most proud of, and what would you do differently next time?
I improved in my CSS skills
What challenges did you encounter, and how did you overcome them?Using the hover effect was difficult.
@PsalmorgPosted 14 days agoI don't check the code but you need to margin-bottom to create space between the profile and the footer text at the bottom, margin at the left hand side of for your link button to centralize it and there should be margin top and bottom for it to create a little bit of spacing. The link button also need a border-radius and try to change profile background color to match the design.
- The font-size of the button also need to be decrease.
- Profile name and the address space it too much. You can try to reduce the default margin bottom or top This is good but you can do better
Marked as helpful0 - @GokulakrishnanMalligeswaranSubmitted 14 days ago@PsalmorgPosted 14 days ago
This is good but i don't understand why you don't use the image given. Also, try to work on your border-radius and box-shadow
0
