Skip to content
OverviewSolutions
26
Comments
36

Pranshu Sahu

@Pranshu-Sahuindia770 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

View more solutions

Latest comments

  • Pranshu Sahu•770
    @Pranshu-SahuPosted about 2 years ago

    Genius Solution without any error

    3
  • Pranshu Sahu•770
    @Pranshu-SahuPosted about 2 years ago

    congratulations on completing the solution.

    I have few suggestions to improve the solution-

    1. <h1 class="sr-only">splitter</h1> <img src="./images/logo.svg" alt="" /> The rule to follow when using heading tags is to never skip the heading level. In other words, heading levels must always be in order to give structure to a page. *this is would remove your first accessibility error. *

    2. You should use the <main> wrapping entire content for the calculator. *this would remove your second accessibility error `

    I hope this helps. Happy coding! 😄

    0
  • Pranshu Sahu•770
    @Pranshu-SahuPosted about 2 years ago

    Hi,

    congratulation for completing the challenge

    I have looked your solution, I see that when I look for advice it produces the same one. You could see my solution, I have added random parameter at the end of api https://pranshu-sahu.github.io/advice-api-fem/ which solves the issue .👌 ✔

    Hope you find it helpful Happy coding

    Marked as helpful
    0
  • Pranshu Sahu•770
    @Pranshu-SahuPosted over 2 years ago

    hi @revin212,

    congratulations on completing the solution.

    I have few suggestions to improve the solution-

    1-- you are missing the separator just below the navbar as shown in the design

    2-- you can take your dropdown one step ahead by getting it close when user clicks anywhere on the document

    3-- I don't know why I'm unable to preview your code. It is showing error 404 page not found. I hope you would fix it.

    hope you find it helpful

    happy coding

    Marked as helpful
    1
  • Pranshu Sahu•770
    @Pranshu-SahuPosted over 2 years ago

    hi @PhoenixDev22, I'm just curious to know how did you make the solution so pixel perfect?

    1
  • Pranshu Sahu•770
    @Pranshu-SahuPosted over 2 years ago

    hi👋 @debriks, you could add aria-label="pricing component range" , this would remove accessibility error.

    Hope you found it helpful Happy coding

    Marked as helpful
    0
View more comments