Any feedback is welcome :)
Paul Toledo
@PaulawlietAll comments
- @Chiku100Submitted over 2 years ago@PaulawlietPosted over 2 years ago
- There is too much space on the right side make sure you centered the body elements you can do it by doing body{margin: 0 auto} to make the content go in the middle and adjust the padding for the spacing left and right
0 - @Ejc2us10Submitted over 2 years ago
I would appreciate your advice on media query: if I wrote correctly etc. Thank you!
@PaulawlietPosted over 2 years agofor media queries I find it easy to do mobile first design before moving to larger screens and it's much easier to code, this is where I studied mobile first design and it helped me for responsiveness: https://www.youtube.com/watch?v=PM3XW_1RAIs&list=PL4cUxeGkcC9hH1tAjyUPZPjbj-7s200a4
1 - @windu80Submitted over 2 years ago
My very first Frontend Mentor challenge.
-- desktop version only for now --
For me, the trickiest part is getting the HTML "skeleton" right. I didn't use any table tag, only a combination of different div to try to get the structure right. But I'm wondering if using a table row, with the left picture and the right product-description as two table cells would have been more efficient. Although, making all the tr and td elements tends to add a lot of (unnecessary?) code and hierarchy levels, so really not sure what's the best way to go. Thanks for helping please!
@PaulawlietPosted over 2 years agoit looks like your github pages has an error, Kindly check because I can't see your live website page
0