Skip to content
OverviewSolutions
2
Comments
2
Noah
@Noke0

All comments

  • Suprefuner•470
    @SuprefunerSubmitted over 2 years ago

    Hi everyone,

    TBH I feel a bit frustrating when I was trying to finish this challenge after finished a udemy course and I thought I can handle this well but turns out I can't. At first I wanted to build this project by using MVC architecture but there is import issue and I can't figure it out so I decided to do it in a beginner way and finally finished it.

    Here are some questions, it would be great if you guys could give me some suggestion and comment!

    1. would it be better if I use <ul> for container and <li> for comment element?
    2. I made a findTargetIndex() function to track the object to modify it's data(since I think I should modify the data instead of just modifing DOM element . Am I right? more like job situation?)
    3. But it makes me have to render everything when any data is changed, is there a way only rerender the element is modified?
    4. How to modify the fill of the score-plus & score-minus svg

    Thanks! (p.s. sorry for my bad naming skill becoz my english is bad and I can't find the right word.)

    JS beginner try to write clean code

    1
    Noah•40
    @Noke0Posted over 2 years ago

    You could search for the element with values which are different from the JSON file and update the element with different values. Another thing you forgot to do is to limit the amount of votes one could give, and also the buttons are a bit small. (i can rate the comment to e.g -400). But these were just minor things, the rest of your website seems nice

    0
  • Darko•980
    @dtomicicSubmitted over 2 years ago

    I've managed to do the challenge but still having some problems with the React code, first one being that some countries pages cannot be entered because the country doesen't have one of the elements that is being shown (for example any island country can't be showed because it doesen't have any border countries and therefore it's giving out some error and displays an empty page), second problem is I haven't figured out how to link the border countries to get to that specific country on click and the last problem is when you're on a country specific page and refresh it gives back a blank page haven't figured out how to fix that.

    If anyone has any feedback or is able to help on these issues I would be more than thankful.

    Countries Website with React

    2
    Noah•40
    @Noke0Posted over 2 years ago

    The search bar is case sensitive but other than that great website!

    1