@denielden
Posted
Hi Darko, great work on this challenge! 😉
Here are a few tips for improve your code:
- React fails in some countries because it expects to receive data that is not there, so to solve this problem you just need to check the data: if the country does not have a certain data then it does not show it on the details page
- to connect the border countries you just need to use the code to retrieve the complete data
- add
header
tag and wrap the navbar for improve the Accessibility - add
main
tag and wrap the content of page for improve the Accessibility - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
- I would also add a query reset button, I find it very convenient
- in the filters there is no way to return to all countries after choosing a region, add an entry "all region"
- to make all flag images the same height use the
object-fit: cover
properties
Overall you did well 😁 Hope this help!
Marked as helpful
@dtomicic
Posted
@denielden thanks for the helpful reply, I'll look into all of the problems to try and fix them all once I get back into this project, I am very satisfied with how it turned out seeing as I'm new to React so a few mistakes here and there don't really bother me haha, thanks for the your time and feedback :D