@bennk0509Submitted 2 months ago
Latest comments
- @NavidSadatPosted 2 months ago
Consistency in Font Sizes: Use relative units (rem) for better scaling across devices. Flexibility with Layouts: Consider flexible max-width properties instead of fixed pixel values. Responsive Design: Ensure all elements scale and adjust properly on different screen sizes. Use clamp() or relative units to make things more fluid. Box Shadows & Card Design: Opt for a softer shadow and ensure max-width is appropriate for larger screens. Improvement in Typography: Ensure font weights and sizes match the design system by utilizing variables for consistency.
0 - @MickeyObasSubmitted 2 months ago@NavidSadatPosted 2 months ago
i have a small suggestion, wouldn't be better if you use main tag in you html?
Marked as helpful1 - @haiderali0509Submitted 3 months ago@NavidSadatPosted 3 months ago
well worked but using strong in html tag, wouldn't be good use css font-weight
0 - @MrabureemSubmitted 3 months ago@NavidSadatPosted 3 months ago
Use LandMark i.e main tag in body. Use width in rem rather than px in .container class. Great Work!!!
0 - @CristianJGonzalezSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I made this challenge in 1 hour.
What challenges did you encounter, and how did you overcome them?I will try to work faster
What specific areas of your project would you like help with?Responsive
@NavidSadatPosted 3 months agopractice make perfect, doesn't matter if you do it in one hour or 2 hours but what matter is the end result all the best for rest
0 - P@CarmenGasSubmitted 4 months agoWhat specific areas of your project would you like help with?
I'd appreciate a code review. Any advice would be greatly appreciated. :)
@NavidSadatPosted 4 months agoUse a descriptive alt text for the QR code (e.g., "QR code linking to Frontend Mentor"). Replace the outer <div> with <main> for better semantic structure, though i used the same div but i realize <main> is much better. Improve text contrast for accessibility and test layout on smaller screens to ensure spacing and readability. Consider reusable class groups and validate spacing/fonts against the design for better scalability and accuracy.
1
