Community feedback

• 

  NavidSadat•100

  @NavidSadatPosted 2 months ago

  Use a descriptive alt text for the QR code (e.g., "QR code linking to Frontend Mentor"). Replace the outer <div> with <main> for better semantic structure, though i used the same div but i realize <main> is much better. Improve text contrast for accessibility and test layout on smaller screens to ensure spacing and readability. Consider reusable class groups and validate spacing/fonts against the design for better scalability and accuracy.

  1
• 

  Kalpesh Patil•150

  @kalpesh172000Posted 2 months ago

  Good things

  • Really nice and clean code. You also added nice comments to denote part of the html file.
  • Solution looks really close to design.
  • Design is responsive.

  what can you improve

  • Use specified font family and colors to make the solution look more close to the design.
  • As you have used flexbox for body tag the content clips at top and bottom when height shrinks too much. To avoid this give min-height to the body so when height shrinks too much it makes the body scrollable and card won't clip.
  • After doing that add 24px padding to body for nice touch.

  0