This challenge was pretty good and any feedback especially critics would be highly appreciated
Naleeka
@NaleekaAll comments
- @BLADEHEDASubmitted about 2 years ago@NaleekaPosted about 2 years ago
Hi @BLADEHEDA ๐
The best practice is not to use px units. Use rem instead
Don't use fixed heights/widths. Ex:
.container{ height:390px; width:530px; }
Use min-height, min-width Ex:
.container{ min-height: 20rem; min-width: 33rem; }
That's why your Add to cart button got out of the container box
- Put whole "container" div in to a main tag
<main> <div class='container'> // your content goes here .... </div> </main>
Nice work buddy ๐ค
Hope this helps.Happy Coding ๐๐ฉโ๐
0 - @Eeshan-VaghjianiSubmitted about 2 years ago@NaleekaPosted about 2 years ago
Both Live site URL & Repository link doesn't work
You may have to check it again
0 - @ROdrigoRRRRDSubmitted about 2 years ago@NaleekaPosted about 2 years ago
Work , play, study .. cards doesn't seem to be working
0 - @MOSCOW2022Submitted about 2 years ago
my 2 problems are: i couldnt center the line through price. i couldnt change the image when we switch to phone view i tried to do the <picture> tag with source but i was so confused and it didnt work so i left it like this
thank you all for your help
- @NelJulganSubmitted about 2 years ago
Responsive page using HTML and CSS flexbox.
feel free to comment.
thank you :)
@NaleekaPosted about 2 years agoHi @NelJulgan ๐
- Use
<footer>
tag to wrap up the elements in bottom of the body
<div class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="https://www.frontendmentor.io/profile/NelJulgan">Neljulgan</a>. </div>
- Use
<main>
instead of<header>
since it's not the heading you are building
<main> <div class="container"> <div class="card"> <div class="card-content"> <img src="./images/image-qr-code.png" alt=" qr-code image" class="qrcode" aria-label="qr-code"> <h3 class="card-title">Improve your front-end skills by building projects</h3> <p class="card-text"> Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </div> </main>
- instead of using alt=" qr-code image" describe where it will be headed, like this ๐ alt="qr-code to FrontendMentor"
Hope this was helpful
Happy Coding Buddy ๐ฉโ๐๐ค
0 - Use
- @osamanazakatSubmitted about 2 years ago
I could not add zoom image. Would anyone help me with that?
@NaleekaPosted about 2 years agoHi @osamanazakat ๐
Answer to your Question,
To zoom the image on hover, You must add overflow hidden to the parent element and scale up the image using transform property.
It'd be like this ๐
// css file .container{ padding: 1.5rem; } .image-container{ width: 100%; overflow :hidden; } .image-container img{ width: 100%; object-fit: contain; transition : transform 0.25s ease; } .image-container:hover img{ transform : scale(1.2); }
If you want to add the eye icon on hover you must follow these steps ๐
(There is maybe another way, this is how I did it)
// html file <div class="img-container"> <img src="images\image-equilibrium.jpg" alt="equilibrium image"> <div class = 'view'> <img src="./images/icon-view.svg" alt="" class="eye-icon" aria-hidden="true" /> </div> </div> // css file .img-container{ position: relative; } .view { position: absolute; width: 100%; height : 100%; padding: 4rem; pointer-events: none; background: var(--cyan-color); opacity: 0; display: flex; justify-content:center; align-items : center; transition : all 0.3s ease; } .img-container:hover .view{ opacity: 1; }
Happy Coding Buddy ๐ฉโ๐๐ค
2 - @melco10Submitted about 2 years ago
I'm a newbie, there's in some code that I'm sure but I'm happily accepting any suggestion and negative feedback to improve my webeev
@NaleekaPosted about 2 years agoHi @melco10 ๐,
Use "alt" attribute and describe the image every time you using the
<Img>
tags<img src="images/image-product-desktop.jpg" alt="add to cart icon" class="product-img" aria-hidden="true">
Happy coding ๐จโ๐
Marked as helpful0 - @Chiku100Submitted about 2 years ago
Can anyone pls help how to change the share icon color when clicked? Other feedback also welcome ;)
@NaleekaPosted about 2 years agoHi @Chiku100 ๐
You could use,
this will work only while you pressing this div though
// css .share:active{ background-color: lighblue; }
or you could use some JavaScript to change the color
//css .share.clicked { background-color: lightblue; } // js file const shareBtn = document.querySelector(".share"); shareBtn.addEventListener('click', ()=> { shareBtn.classList.add("clicked"); })
Great work.
Hope this was helpful.
Happy Coding ๐จโ๐๐ค
Marked as helpful1 - @alexanderbonneySubmitted about 2 years ago
As always, your feedback and comments are highly appreciated.
@NaleekaPosted about 2 years agoHi @alexanderbonney ๐
You've been really creative with the hover effects ๐๐
I think something that you could change is,
- Put all
<section>
s inside a<main>
tag to fix the accessibility issue you have
Great work, Happy Coding ๐จโ๐๐ค
Marked as helpful0 - Put all
- @mcddcmSubmitted about 2 years ago
What are the best practices to follow when resizing a styled <img> using {background: url(...)}?
@NaleekaPosted about 2 years agohello @mcddcm ๐
You could use
<h1>
tag instead of<h3>
tag and change it's font-size to fix the accessibility issue.Use media queries to make the component responsive
@media screen and (min-width: 375px;){ .product-card{ width:30vw; } }
hope this was helpfull
happy coding ๐
Marked as helpful0 - @osamanazakatSubmitted about 2 years ago
I could not make it responsive. Can anyone help me with that?
@NaleekaPosted about 2 years ago- favicon doesn't work because of spelling mistakes. It should belike this ๐
< link rel="icon" type="image/png" sizes="32x32" href="./images/favicon.png" />
- You could use media queries to make the website responsive.
Ex:-
@media screen and (min-width: 768px){ .selector{ width: 30vw; } }
hope this was helpful. Happy Coding๐ฆธโโ๏ธ
Marked as helpful1 - @zineb-BouSubmitted about 2 years ago
Hi everyone, it's been a long time since my last submission here on Frontend Mentor, this time I tried to build a real-time commenting system inspired by the Interactive Comments Section challenge, I have used different technologies over here, using firebase in the backend and Nextjs as a framework, the thing that helped me to keep it at real-time is using the SWR library, this time I chose tailwinds for styling as it is easy to set up, plus I want to focus more on the how to generate and save data.
take a look at my solution, test it by leaving a comment, and any feedback is welcomed. happy coding :)
@NaleekaPosted about 2 years agoThis is really cool
I don't know about the language u made this with, but I don't think the upvote button works correctly .
I can upvote a comment more than once
happy coding buddy ๐
0