Skip to content
OverviewSolutions
25
Comments
11
Martha
@Mtc-21

All comments

  • Kenā€¢4,915
    @kens-visualsSubmitted almost 3 years ago

    That's it, this is the last challenge in JUNIOR level šŸ„³, and I managed to finish the whole section within a month. Which also means that I've reached my goal of finishing all projects in JUNIOR level before the end of the year šŸ¤© I'm really excited about this and what's coming next, in terms of projects and all the cool stuff that I'm going to learn and practice. Before starting the next level, I'm planning to learn React and start the upcoming projects with it, because I feel quite confident in Vanilla JS and DOM manipulations. So, I don't want to miss the chance of practicing React with all those awesome projects in INTERMEDIATE level. I wish you all happy holidays and happy coding šŸ‘ØšŸ»ā€šŸ’» Cheers šŸ‘¾

    If you have suggestions, drop them in the comments' section šŸ‘ØšŸ»ā€šŸ’» Cheers šŸ‘¾

    Huddle Landing Page with Curves built with Vanilla JS, SCSS, and BEM

    1
    Marthaā€¢510
    @Mtc-21Posted almost 3 years ago

    hi congratulations, your all jobs are great! how did you learn all this? some tutorial, book or website you recommendend, i didn't know the intersection observer API, it looks great. I have knowledge in css, html and js, but if I don't arrived here, it would take me months to know that it exists this API

    1
  • Marthaā€¢510
    @Mtc-21Posted almost 3 years ago

    Hi merry christmas, thanks for your comments and the suggestion šŸ‘, i have applied some of your suggestions, I haven't applied the fieldset tag change yet, but I understand you say the relation with sr-only.

    1
  • Marthaā€¢510
    @Mtc-21Posted almost 3 years ago

    greetings some recommendations:

    • make an effective validation of the fields, that indicates to the user a message with the errors.
    • do not allow data in negative, leading zeros, the following 0123 is taken as a positive number.
    • do not allow data like this 12-2
    • no decimals should be allowed in the person field in addition to the above.
    • in the person field a number >100 should not be allowed in addition to the above
    • the number of persons should not be greater than the invoice number, invoice to 1 and persons to 50, it does not make sense.
    • If you hover over the field and delete the information, the totals should be reset according to what is entered in the field.
    • see the accessibility issues thrown at the time of loading the challenge, they are helpful.
    Marked as helpful
    1
  • Marthaā€¢510
    @Mtc-21Posted almost 3 years ago

    greetings some recommendations:

    • make an effective validation of the fields, that indicates to the user a message with the errors.
    • do not allow data in negative, zeros to the left, the following 0123 is taken as a positive number
    • do not allow data like this 12-2
    • in the person field no decimals should be allowed in addition to the above
    • in the person field a number >100 should not be allowed in addition to the above
    • the number of persons should not be greater than the invoice number, invoice to 1 and persons to 50, does not make sense.
    • If you position over the field and delete the information, the totals should be reset according to what was entered in the field.
    Marked as helpful
    0
  • Marcus Hugoā€¢365
    @marcus-hugoSubmitted almost 3 years ago

    This is the most JavaScript I've written for a challenge! Should the display show NaN and Infinity or just '0.00' when the inputs aren't filled in? I think I started out with an organized approach, but by the end, felt it could be simplified! Should I have kept more variables on a global scope? Should I have had more functions?

    Tip Calculator App with Vanilla JS

    3
    Marthaā€¢510
    @Mtc-21Posted almost 3 years ago

    greetings some recommendations:

    • make an effective validation of the fields, that indicates to the user a message with the errors.
    • do not allow data in negative, zeros to the left, the following 0123 is taken as a positive number
    • do not allow data like this 12-2
    • in the person field no decimals should be allowed in addition to the above
    • in the person field a number >100 should not be allowed in addition to the above
    • the number of persons should not be greater than the invoice number, invoice to 1 and persons to 50, does not make sense.
    Marked as helpful
    0
  • Marthaā€¢510
    @Mtc-21Posted almost 3 years ago

    greetings I recommend you to see the accessibility problems thrown at the time of loading the challenge, are of great contribution for future projects, additionally

    • make an effective validation of the fields, which indicates to the user a message with the errors
    • do not allow data in negative, leading zeros, the following 0123 is taken as a positive number
    • data like this 12-2 should not be allowed
    • in the people field it should not allow decimals in addition to the above -in the custom field it should not allow in addition to the above a number >100; -the color of the reset field is as gray starting with
    0
  • Marthaā€¢510
    @Mtc-21Posted about 3 years ago

    1)Hi excellent work, in the mobile version the email validation does not work, the logos belong in the footer and copyright.

    2)Suggestion, see the accessibility reports and use some css and html validator before uploading the content, it will help you a lot.

    0
  • Marthaā€¢510
    @Mtc-21Submitted about 3 years ago

    I had problems with the alert image, when selecting a wrong email from the list of options that shows the input of those previously entered, it does not show the image, it is only shown when entering keyboard entries, any recommendations? thanks

    Base Apparel coming soon page using css flexbox and grid

    3
    Marthaā€¢510
    @Mtc-21Posted about 3 years ago

    I have found the answer to my question, I hope it will help someone here is the link to the answer and a possible solution

    0
  • Marthaā€¢510
    @Mtc-21Submitted about 3 years ago

    I had problems with the alert image, when selecting a wrong email from the list of options that shows the input of those previously entered, it does not show the image, it is only shown when entering keyboard entries, any recommendations? thanks

    Base Apparel coming soon page using css flexbox and grid

    3
    Marthaā€¢510
    @Mtc-21Posted about 3 years ago

    other than disabling the autocomplete attribute of the input, thank you.

    0
  • Jurjenā€¢90
    @snhmibbySubmitted about 3 years ago

    Couldn't get the city name right without fucking up the html code to have it outside the 'name-age-city'-section. Would appreciate hints to get it working and have the city paragraph inside this section!!

    flex/grid approach

    1
    Marthaā€¢510
    @Mtc-21Posted about 3 years ago

    Hello, your design is fine, I would only add the background images with a background-image:url() to the body, with background-position: place one to the left and the other to the right, with the following link you can support Link, with the positioning, I recommend you to work with vw so that they remain in the same place.

    • for your card to be centered you must set the html tag and the body in min-height:100vh, if you set only the body in height:100%, it will not work, as far as possible avoid using % or absolute units such as px, it is recommended to use rem or in some examples of use

    • there should be only one h1 tag in the document, normally inside the main, outside tags like div, section, article, etc, tags like section and article should have some descriptive title tag, between h2 and h6, I recommend you to read some html semantics, here some support links Link 1 Link 2

    • additionally it would be ideal that you see in the section of report the problems of accessibility or html that presents the site that you created, always they provide you a link of reference to correct the error.

    Excellent work šŸ‘

    Marked as helpful
    1
  • Marthaā€¢510
    @Mtc-21Posted about 3 years ago

    hello your design looks very good, the border thing you mentioned happened to me, it's more noticeable when you work with rem, that's why I used px and as the px value increased, the empty space was no longer visible, try it.

    Marked as helpful
    1