Design comparison
Community feedback
- @IvanaCliffordsPosted about 3 years ago
I also did border : 8px solid white, and the empty space would shrink or get bigger depending on the number of the pixels that I chose.
Marked as helpful1 - @Mtc-21Posted about 3 years ago
hello your design looks very good, the border thing you mentioned happened to me, it's more noticeable when you work with rem, that's why I used px and as the px value increased, the empty space was no longer visible, try it.
Marked as helpful1 - Account deleted
I am not sure what you mean by the first question, but I think the way you handled the background shapes is ok.
On your css there was no need for
.card__info-image::before
, you could have just added;border : 2px solid white
on the image and saved yourself some time...Btw your solution looks good.
Keep coding👍.
Marked as helpful1@CyrusKabirPosted about 3 years ago@thulanigamtee thanks my friend yes i know i try that but have problem i don't know how to say i mean if you see the image it's have some empty space around of it when we do in this way for adding border to a rounded image i don't know it's a bug or a problem in my code but at all i try to adding border but that problem made me to do with ::before at all thanks for your feedback ♥♥♥ (sorry if my english is bad i am working on it)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord