@CairoGarbSubmitted 9 months ago
+1 project done! Any tips or tricks to improve the code will be appreciated, thanks!
P
Zephyr_Grey
@Mercury225All comments
- @Mercury225Posted 9 months ago
Hi there! The HTML code is clear and uses semantic marking. I would look more into accessibility coding for HTML (aria roles), as well as adding name attributes for input tags. I would also try to reduce the CSS, there are 1800 lines of code for this website. Keeping code simple and short will help people navigate through your code. Otherwise great job!
Hope this helps!
Marked as helpful0 - @080AasimSubmitted 10 months ago
Please provide feedback.
@Mercury225Posted 10 months agoLooks all good to me! The only thing is the heading a bit bigger than the original, i would lower the font-size by a little.
<body><h1>Jessica Randall</h1><h4>London,United Kingdom</h4></body>h1 22px h4 ( should be h2) 18px
0 - @devid8642Submitted 10 months ago
About the colors used in this project. I applied the color "light gray" to the text "Scan the QR code to visit Frontend Mentor and take your coding skills to the next level" and it was very faded in relation to the background color of the card. So I had to use a darker shade of gray. What do you think about this, was this shade of gray the right one and was I doing something wrong about applying it?
@Mercury225Posted 10 months agoHi there, Great job! I'm having a look at your code and there are some things that stick out to me:
In index.html you write your CSS in your html
-It's common practice to put this code in another CSS file (call it maybe styles.css) and to put a HTML link tag to the CSS file.
- margin: 50px auto 0; is better
-Using px is fine, but for responsive design purposes, it's usually a better habit to use the unit rem, or em, to make it easier for resizing for bigger projects
And about the shades of grey, the darker background grey looks a bit sinister, i would stick with a lighter shade
Hope this helps!
Marked as helpful2
