@Mercury225
Posted
Hi there, Great job! I'm having a look at your code and there are some things that stick out to me:
In index.html you write your CSS in your html
-It's common practice to put this code in another CSS file (call it maybe styles.css) and to put a HTML link tag to the CSS file.
- margin: 50px auto 0; is better
-Using px is fine, but for responsive design purposes, it's usually a better habit to use the unit rem, or em, to make it easier for resizing for bigger projects
And about the shades of grey, the darker background grey looks a bit sinister, i would stick with a lighter shade
Hope this helps!
Marked as helpful
@devid8642
Posted
@Mercury225 Thank you very much for the tips! Regarding CSS in HTML, I chose to do it this way because it was a simple case of styling just one page. However, I will try to follow good practices from now on.
I didn't know about this good practice of relative length units (em, rem). I will research more about it and see how I can apply it to my projects.
Regarding the issue of colors, I believed that I should use the colors exactly as they are defined in style-guide.md. But I see that there is complete freedom to make adaptations without going much beyond the original color palette.
Again, thank you for your help and your time.