Submitted
A nice fun project, and i've successfully used JSON which works on all platforms. I realised i was doing my fetching syntax incorrectly, and managed to correct it for my other projects!
@Mercury225
Submitted
A nice fun project, and i've successfully used JSON which works on all platforms. I realised i was doing my fetching syntax incorrectly, and managed to correct it for my other projects!
Submitted
Some comments
had a lot of fun doing the password JS code, and thoroughly enjoyed the challenge! if you can help on this:
Wasn't very sure how to customise the slider using the input tag type = range. I wanted to change the color of the slider-thumb to grey but was unsuccessful, if you can help on this please!
I tried this: #length-number { background-color: transparent; appearance: none; } #length-number::-webkit-slider-runnable-track { background-color: $green; } #length-number::-webkit-slider-thumb { background-color: $grey; }
webkit-slider-thumb didn't work, but runnable-track did, still it just gave a green background with a blue thumb, which is not what i want
so i ended up just doing this: #length-number { accent-color: $green; }
Submitted
One of my absolute favourites comments -i learnt so much! It was my first time drawing the ring counter, which was exciting, and my first time using the forEach function on arrays -i customised a lot of this using Javascript, which was a challenge in its own -Had a lot of fun! in my next project -i will stick to a BEM naming convention for my CSS next round -i will try to group together elements into arrays and use forEach, which saves a lot of coding lines -i will use more deconstructing and spread operators consistently instead of coding for each individual element If you can help -Please could you suggest cleaner and more efficient code, or any methods that i have used which is cumbersome, looking for the most efficient way to represent my code.
Submitted
Submitted
** General Comments **
** Things to work on/ ask about **
Submitted
Improvements made
Since the previous project on single-price-grid-component-master, i have made some improvements to my coding which has doubled time efficiency allowing me to complete this project quickly
plain background as from the design image a consistent class naming system using ARIA tags and landmark main in HTML using colors in variable names first in CSS I found that a consistent width and height for this worked on all devices, quick fix! Didn't need to use flex either
Some changes:
Submitted
What did you find difficult while building the project?
COLLECTIVE ANSWER: Which areas of your code are you unsure of?/ Do you have any questions about best practices?