@ArShadhinJrSubmitted about 1 year ago
Mahmoud_Amin
@Mahmoudamin11All comments
- @Mahmoudamin11Posted about 1 year ago
hello , great work bro :). That's awesome. I just want to ask how did you or what did you use for uploading the project to githup and deploying it ?
0 - @nour-elhabbalSubmitted about 1 year ago
Built with:
Vanilla js - Css- Html@Mahmoudamin11Posted about 1 year agogreat work man :)
- but u have a problem that after calculating the tip everything is well no problem but if the user changed the bill nothing happens and the value isnot updated . so u have to do calculating after blur the bill input and check that the rest of the inputs are well before calculating to avoid appearing NaN or Undefined Thanks :)
Marked as helpful0 - @lawrence-yoonSubmitted about 1 year ago
How different is modern ecommerce form validation to my code? I imagine that form validation could be an entire field of work, and there is a lot of money in ecommerce. I can see how it can be over-engineered, but I also understand that validation could provide protection from xss or sql injections or other malicious activities.
- @Ansh-Malik1Submitted about 1 year ago@Mahmoudamin11Posted about 1 year ago
Great work, Keep going you are doing awesome : ) but i think you didn't use the font needed in the design or the required colors put in the style guide file
0 - @BrunnoHibbelnSubmitted over 1 year ago
Hey guys, in my last projects I received several feedbacks advising me to make a more semantic html. I did the best I could but I'm still confused when to use <section> and <article> for example. I also tried to use "rem" instead of pixels, but I still have doubts about how it works. And finally, is there any better way to implement the icon overlay?
Thanks for the feedbacks, they help a lot!
@Mahmoudamin11Posted over 1 year agorem => stands for the root which is html like font Size for example in the root it is always 16px so if you used 2rem it means 2 * 16 = 32px
em=> stands for the body which is my default it's like html but you can change it like body {font-size: 15px;} in this case you made the font size em = 15 so font-size: 2em; means 30px ;
- Awesome work by the way : )
Marked as helpful1 - @mooogzSubmitted over 1 year ago@Mahmoudamin11Posted over 1 year ago
Nice job : ) in the hover of the button try to make make it smooth by giving it => transition: 0.3s; and make the cursor: pointer; that will be much better
- And the background is white : )
- Awesome work never stop
0 - @Navi003Submitted over 1 year ago
Hi there,
i build this in 90 mins :) took a bit long i guess but yes it was nice and Easy challenge really enjoyed it using vanilla JS and CSS after long time :) . any feedback is welcome.
cheers Navi
- @PepeleenoSubmitted over 1 year ago
Any feedback is welcome
- @JosephEllieSubmitted over 1 year ago
Adding the active state to the image
@Mahmoudamin11Posted over 1 year agomake the body flex and flex-direction: column; and justify-content: center ; to make the card in the middle and nice work keep going . but you forgot to make the active part in the bottom paragraph and the h2 and the image there is hover in them
Marked as helpful1 - @vieyrapSubmitted over 1 year ago@Mahmoudamin11Posted over 1 year ago
nice work just make border:none; for the button and maybe you forgot the hover (cause there is active here)
Marked as helpful0 - @ManuelPianoSubmitted over 1 year ago
- @KiruthikaKanaguSubmitted over 1 year ago
Here is my solution.All comments are welcome.
@Mahmoudamin11Posted over 1 year agohello there first that was a really great work and nice screen i just have 3 notes 1- Create border-radius 2- change the body background color 3- remove the border of the button => border: none;
0
