Mahmoud_Amin• 540
@Mahmoudamin11
Posted
Great work dude : )
Marked as helpful
1
Design comparison
Solution retrospective
Hi there,
i build this in 90 mins :) took a bit long i guess but yes it was nice and Easy challenge really enjoyed it using vanilla JS and CSS after long time :) . any feedback is welcome.
cheers Navi
Community feedback
Tushar Biswas• 4,080
@itush
Posted
Congratulations on completing the challenge! 🎉
Nice attempt :)
-
Image alternative text is not present for
icon-success.svgThis might look very frivolous but this is an accessibility issue. Each image must have an alt attribute. Without alternative text, the content of an image will not be available to screen reader users or when the image is unavailable. -
The Thank you page is not centered for 460px and down screens.
-
The error messages & red input border does not reset after hitting Dismiss message.
-
Feel free to go study my solution to get some ideas about the structure, styling and the JS validation.
In my projects:
- I always start with mobile-first workflow.
- I use at least one main element for a page (entire content goes into the main, if I'm not using header & footer), and avoid divs as much as possible and use section and article element wherever I can.
<body>
<main>
All content
</main>
</body>
-
I Use relative units as much as possible and avoid absolute units whenever possible.
-
If you are someone who is just starting out with front-end development, I strongly suggest starting with the QR code component project(which you did). Also in the challenges page you may filter by (Newbie, HTML&CSS) sort by (easier first) to select projects that will help you solidify your foundation. To avoid any potential knowledge gap⚠️ please first solidify HTML, CSS, JS fundamentals, make few projects only with the trio and then move on to any framework or library.
-
I remember when I started out, I made countless mistakes and spent long hours searching for solutions. But hey, you don't need to go through the same struggles! 🙌 To help you shorten the learning curve, I recommend going through the following articles. They contain valuable insights that can make your journey smoother:
📚🔍 12 important CSS topics where I discuss about css position, z-index, box-model, flexbox, grid, media queries, mobile-first workflow, best practices etc. in a simple way.
📚🔍 11 important HTML topics where I discuss about my thought process and approach to convert a design/mock-up to HTML along with important topics like block and inline elements, HTML Semantic Elements, accessibility.
I hope you find these resources somewhat helpful in your coding adventures! 🤞
I'm eagerly looking forward to seeing the amazing projects you'll create in the future! 🚀💻
Keep up the fantastic work and happy hacking! 💪✨
Feel free to ask more questions☺️
Marked as helpful
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord