P
@khalidanejjarSubmitted 4 months ago
Latest comments
- P@Maanlicht91Posted 4 months ago
Congrats on completing this challenge! Nice and clean code. It's good to see you using grid-template-areas and named it. But I would suggest you to use some meaningful names instead one two three. But of course still easy and clever to use it. And you forgot to add quoatation svg you could do that with mask-image property in css. You can search more about it. Keep working!
Marked as helpful1 - @mdchongSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I am so proud that the time I spend creating my HTML/CSS is shortening! For my next challenge, I will try to set up a time to finish my layout rather than timing how long it takes! I am also falling in love with using clamp()! It makes it much easier to control the page than do it all individually using media query.
What challenges did you encounter, and how did you overcome them?The challenge I encountered was using box-shadow, especially to make it the left and right shadows lighter than the bottom part of the card. Though, I figured out it can be controlled by using opacity!
What specific areas of your project would you like help with?Total layout of the HTML/CSS. And I am willing to gain help with making my SASS/SCSS much more convenient and cleaner!
P@Maanlicht91Posted 5 months agoCongrats completing this challenge. I love using scss for clean and nested code. I see you don't use nested feature of scss. I would recommend you check BEM (Blocks, Elements, Modifiers. Its very useful with scss. Also I will search about clamp now thanks to you I never used it. But looks like is good for responsive typography. Keep working.
Marked as helpful0 - @artemkotko14Submitted 5 months agoP@Maanlicht91Posted 5 months ago
Congrats on completing this challenge. I'm happy to see people using scss which is very useful for designing.
0 - P@souleymane-dialloSubmitted 5 months agoP@Maanlicht91Posted 5 months ago
Congrats on completing this challenge. I liked your class name style Jonas taught me this technique especially its useful for scss and sass. Keep going to improve your coding skill.
0 - @Shanxx191919Submitted 5 months agoP@Maanlicht91Posted 5 months ago
Nice one. Probably you didn't give attention on class names because of mini simple project. Otherwise giving all tags class name for css and id for js is best option and very clear code. This way is hard to understand what is p.one or p.grey if you had huge style codes but ofc this is a simple basic project. No harm to do like this
Marked as helpful0 - @sevaaaDevSubmitted 5 months agoP@Maanlicht91Posted 5 months ago
Nice try. But I suggest you to start with this code for most css:
- { margin: 0; padding: 0; box-sizing: border-box; } body { font-family: "Figtree", sans-serif; }
if you want container(wrapper) in the mid of page you can add some properties in body also:
body { font-family: "Figtree", sans-serif; display: flex; flex-direction: column; align-items: center; justify-content: center; min-height: 100vh; }
0
