Social Links Solution

Community feedback

• 

  P

  Aynur Demir•150

  @Maanlicht91Posted 7 days ago

  Nice one. Probably you didn't give attention on class names because of mini simple project. Otherwise giving all tags class name for css and id for js is best option and very clear code. This way is hard to understand what is p.one or p.grey if you had huge style codes but ofc this is a simple basic project. No harm to do like this

  Marked as helpful

  0

  ---

  

  Shanxx191919•60

  @Shanxx191919Posted 7 days ago

  @Maanlicht91 how do I improve this?

  0

  

  P

  Aynur Demir•150

  @Maanlicht91Posted 6 days ago

  @Shanxx191919 Even its small project try to give class names to each elements and a clear name For instance;

  <div class="container"> <div class="person-info"> <img class="person-photo"> <h1 class="person-fullname"> </h1> <p class="person-occupation"> </p> <button class="btn person-social-link"> </button> </div> </div>

  If you are working with JavaScript then give id that specific element maybe button you want to click and do something.

  0

  

  Shanxx191919•60

  @Shanxx191919Posted 4 days ago

  @Maanlicht91 okay thanks for this, I'll practice this in my future projects

  0