All feedback is welcome
Khalid Khabouz
@KhalidKhabouzAll comments
- @keerthi797Submitted about 1 year ago@KhalidKhabouzPosted about 1 year ago
Nice job, just try to use semantic elements as a habit for the long term, to help the search engines and other user devices to determine the importance and context of web pages.
Generally you did a good job keep up.
Marked as helpful0 - @oussamataali97Submitted almost 3 years ago@KhalidKhabouzPosted almost 3 years ago
The layout looks nice, good job for this one. But I just have some remarks to improve the accessibility issues.
- Try to wrap your section element inside the main tag.
- Try to wrap the attribution div inside a footer tag.
Also to improve the typography of your design, use the font provided in the style-guide.md file.
Good job and happy coding
Marked as helpful0 - @KhalidKhabouzSubmitted almost 3 years ago
I've just completed this challenge, it was helpful. Thanks for stopping by.
@KhalidKhabouzPosted almost 3 years agoThat was so informative and helpful, you are right, it is better to build good practices as a foundation. Thank you for your time.
0 - @KhalidKhabouzSubmitted about 3 years ago
This is my solution for this challenge. It was a good thing to work with multiple background images using CSS. Thank you for stopping by.
@KhalidKhabouzPosted about 3 years agoThank you so much for all these remarks, it was very helpful for me to build and develop a good practice. Thanks again for your time for stopping by.
1