nft preview card component HTML & CSS

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 3 years ago

  This looks really nice overall, well done

  Just a few pointers on the html:

  • if the image shows interactivity, it needs to be wrapped in an interactive element (like an anchor tag or button). The eye icon overlay implies it is clickable and something would heppen there
  • Look up how to write good alt text. It's ok but should never say words like "image" as it's already an image by the fact it's an image tag
  • The "creation of" line can't be a h2. It has no content underneath it so that doesn't make sense. It would make more sense if this whole card was a figure element, then that bottom section could be the figcaption (still not heading element through)

  Sounds like small picky things, but important to get these foundations right in every project

  Marked as helpful

  1
• 

  Khalid Khabouz•190

  @KhalidKhabouzPosted almost 3 years ago

  That was so informative and helpful, you are right, it is better to build good practices as a foundation. Thank you for your time.

  0