Profile Card Component HTML, CSS, SCSS

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, awesome work on this one. Layout in general looks great.

  Some suggestions would be:

  • Avoid using height: 100vh or height: 100% on a large container like the body as this makes the element's height capped based on the viewport/screen's height. Instead use min-height: 100vh so that the element will expand if it needs to.
  • Person's image should be using the person's name as the alt value like alt="Victor Crest". Components like this where a person's information is presented, make sure to use their name as the person's img alt value.
  • When using img tag, you don't need to add words that relates to "graphic" such as "profile, image" and others, since img is already an image so no need to describe it as one.
  • You could have used ul for the .card__footer selector since those are list of items that are inside it.
  • Also, those text inside the .card__footer are not suitable to be heading tag, because by making it one, 80k does not give any information about the section right, so it will be better to just use p tag.

  Aside from those, great job again on this one.

  Marked as helpful

  1
• 

  Khalid Khabouz•190

  @KhalidKhabouzPosted about 3 years ago

  Thank you so much for all these remarks, it was very helpful for me to build and develop a good practice. Thanks again for your time for stopping by.

  1