Skip to content
OverviewSolutions
18
Comments
5
Kathryn
@KathrynDavies123

All comments

  • Kathryn•320
    @KathrynDavies123Posted almost 2 years ago

    Hi Reivaj,

    I achieved the background color when the burger menu is open by having a div container over the entire screen (adjust the z-index if you need to, so it is "behind" the nav menu), that has the required background color. I gave it opacity 0 and then when the menu is open, added into my function that a new class should be given to it with a higher opacity so that it shows up. I also added a transition to it so that it looks a bit smoother.

    Hope this helps!

    Kathryn

    0
  • Kathryn•320
    @KathrynDavies123Posted almost 2 years ago

    Hi Hector! :)

    First of all really nice job with this challenge!

    One thing I did notice while clicking around was that when the submit button is clicked more than once and correct info is still not entered, the styling of the error messages and the error icons go away. Try to implement something that keeps the error messages and styling consistent as long as the inputs are not filled/email address is not valid.

    Hope this helps!

    Kathryn

    0
  • Kathryn•320
    @KathrynDavies123Posted almost 2 years ago

    Hi!

    First of all nice job on this :)

    One thing you should consider adding is some kind of restriction on the submit button, since at the moment the form can be submitted without any rating number being selected. This takes the user to the second screen and the part where the rating should be is empty.

    Good luck, and let me know if you get stuck!

    Kathryn

    Marked as helpful
    0
  • Kathryn•320
    @KathrynDavies123Posted almost 2 years ago

    Hi Sonu :)

    The design looks great!

    Just one thing I noticed while testing out the form:

    When you do not enter anything into the fields, the errors pop up as expected, however clicking the submit button again after that "resets" everything and the error goes away. Try to implement something that will keep the error messages there as long as the input fields do not have the required information. You should be able to do this using "if" statements.

    Hope this helps!

    Kathryn

    Marked as helpful
    0
  • Kathryn•320
    @KathrynDavies123Posted almost 2 years ago

    Hi JJ :)

    This is great! The only thing I would add is some kind of functionality that the form will only be submitted when one of the rating numbers is selected. At the moment, it can be submitted when nothing is selected and it will go to the submitted state with "undefined" as the rating number.

    This will require a bit of tweaking of your Javascript so that the submission function is only available once a rating has been selected.

    Hope this helps a bit!

    Kathryn

    Marked as helpful
    0