Interactive Rating Component

Community feedback

• 

  Kathryn•320

  @KathrynDavies123Posted almost 2 years ago

  Hi JJ :)

  This is great! The only thing I would add is some kind of functionality that the form will only be submitted when one of the rating numbers is selected. At the moment, it can be submitted when nothing is selected and it will go to the submitted state with "undefined" as the rating number.

  This will require a bit of tweaking of your Javascript so that the submission function is only available once a rating has been selected.

  Hope this helps a bit!

  Kathryn

  Marked as helpful

  0

  ---

  

  JJ•160

  @JeremyPaymalPosted almost 2 years ago

  Hello @KathrynDavies123,

  I did it like this :

  function submission() { if (selection.isNaN) { } else { document.getElementById("rating_state").classList.add("hidden"); document.getElementById("chosen_rating").innerText = selection; document.getElementById("thanks").classList.remove("hidden"); } }

  It works but is it a good way to do it ?

  Thks !

  Jérémy

  0

  

  Kathryn•320

  @KathrynDavies123Posted almost 2 years ago

  Hey, @JeremyPaymal

  It works so first of all nice job on that!

  I would say this is fine, I did the function slightly different when I solved this. I used addEventListener on the number buttons and then put the submit function directly into the event listener of the buttons, so it just would not even be active until one of the buttons was pressed.

  You can see my solution here if you want to check it out: https://github.com/KathrynDavies123/interactive-rating-component

  Kathryn

  0

  

  Kathryn•320

  @KathrynDavies123Posted almost 2 years ago

  Hey, @JeremyPaymal

  It works so first of all nice job on that!

  I would say this is fine, I did the function slightly different when I solved this. I used addEventListener on the number buttons and then put the submit function directly into the event listener of the buttons, so it just would not even be active until one of the buttons was pressed.

  You can see my solution here if you want to check it out: https://github.com/KathrynDavies123/interactive-rating-component

  Kathryn

  Marked as helpful

  0