Intro component & sign up form | Mobile First | CSS Grid | Responsive
Design comparison
Solution retrospective
Hello Friends,
Please review my code, any feedback or suggestions from yours will be very beneficial to me
Thank you!
Community feedback
- @KathrynDavies123Posted almost 2 years ago
Hi Sonu :)
The design looks great!
Just one thing I noticed while testing out the form:
When you do not enter anything into the fields, the errors pop up as expected, however clicking the submit button again after that "resets" everything and the error goes away. Try to implement something that will keep the error messages there as long as the input fields do not have the required information. You should be able to do this using "if" statements.
Hope this helps!
Kathryn
Marked as helpful0@SonuKr95Posted almost 2 years ago@KathrynDavies123 Thank you for your suggestion, I will include all the changes as highlighted by you. I appreciate the support and guidance from you.
1 - @Victor-NyagudiPosted almost 2 years ago
Hello, Sonu.
Nice try on this one.
You have quite a bit of HTML validation errors I would suggest looking into before submitting your solution.
For example, one occurs because you used a
<p>
tag inside a<span>
here.<button class="btn" id="btn-purple"> Try it free 7 days <span> then <p>$20/mo. thereafter</p> // <- This is invalid HTML </span> </button>
A
<span>
is an inline element (it only takes up as much space as it needs to), so it can only have other inline elements inside it e.g.<a>
.A
<p>
tag is a block-level element (takes up the full width of its container) and starts on a new line. Another example is a<div>
. These can have other block-level elements inside them or inline elements.Replace the
<p>
with a<span>
, and the error should go away. This is okay because you can have a<span>
inside another<span>
.You can read more about inline elements and block-level elements here to gain a better understanding of how they work.
Hope this helps.
All the best with future solutions.
Marked as helpful0@SonuKr95Posted almost 2 years ago@Victor-Nyagudi Thank you for your suggestion, I will include all the changes as highlighted by you. I appreciate the support and guidance from you.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord