Marijanjghhava• 180
@Marijanjghhava
Submitted
What are you most proud of, and what would you do differently next time?
all feedback is welcomed.
Jvps321
@Jvps321
All comments
- Jvps321• 50
@Jvps321
Posted
It's good, you just forgot to put the period on line 21 in " <img src="/images/avatar-michelle.jpg", the period was missing before /images. example src="./images/avatar-michelle.jpg " the same thing happened for the other image but this one is in the css on line 25. Hope this helps
0 - able c j• 70
@ablecj
Submitted
What are you most proud of, and what would you do differently next time?
I able to complete the code.
What challenges did you encounter, and how did you overcome them?
main challenge is finding the way to implement the design.
What specific areas of your project would you like help with?
i have face an issue. when i increase the height of the screen there is creating the empty white space.
Jvps321• 50@Jvps321
Posted
To avoid white space, remove the "height" container. why are you saying it should be the height of the screen, but if you get a bigger screen, the container will be gigantic, but the content will always take up the same space, hence the blank space. and its responsive mode is breaking when the screen goes below 650px I recommend taking a look at this point too, if you need help just let me know and I'll try to help. Hope this helps.
0 - brianopedal• 40
@brianopedal
Submitted
What are you most proud of, and what would you do differently next time?
Using plain css & html. Not sure about the difference.
What challenges did you encounter, and how did you overcome them?
The mobile first part is not implemented yet.
What specific areas of your project would you like help with?
The mobile part, with media queries.
Jvps321• 50@Jvps321
Posted
I noticed that it was bigger than proposed and when trying to make it in mobile size, half of the site becomes unavailable because it goes up and there's no way to see it, to fix this just remove the "height" of the boby. A tip is also to add a “div” to cover the entire content of the site, but leaving the “picture” tag out to facilitate responsiveness. As for making it responsive, just take it and put a "@media screen and(max-width:590px) {what should be changed}", an example of what you can change, if you added the extra div you You can remove the "padding" from the article and place the "padding" in the extra div to leave the image occupying one side of the screen to the other in addition to removing the "border-radius" from the image. If you have any doubts about something I said and want to see how I did it, link to my GitHub: https://github.com/Jvps321/recipe-page-main
0 - Jvps321• 50
@Jvps321
Posted
It was good, but when you mentioned the qr code, on line 23 you forgot to put the ".", leaving "/images/image-qr-code.png", there should be a period before "/images" like " . /images" In the beginning that was why the image didn't appear. Regarding HTML, it's fine. You could make it more semantic by replacing the qr-container div with the main tag, and if you wanted, you could leave the image in one div and the texts in another div. the css is good. I'm not very good, but if you want to look at my code to better see what I mentioned, my css ended up being a little big, as I was trying to make it as similar to what was proposed and as semantically as possible. link GitHub: https://github.com/Jvps321/landing-QR-code-component
0 - alvarozama• 360
@alvarozama
Submitted
What are you most proud of, and what would you do differently next time?
The thing I'm most proud of is having been able to use Git since I had no idea what it was and in the process of setting it up I thought I was gonna have to upgrade my laptop due to a lack of storage space, but I ultimately found I way I could use it without having to do any etreme changes to my setup.
What challenges did you encounter, and how did you overcome them?
This is the firs challenge on the learning path and honestly I'm still not sure how this whole thing works. For example, the style guide stated thet I shoulde use a certain color for the background of the page, however, that specific shade of gray was much darker that the one shown in the example jpg provided, so I was unsure about wether or not I should have strictly stuck to the design guidelines or if I could take the freedom to do deviate from it in order to better match the example design. I ultimately ended up using an online color picker to better match the design example.
What specific areas of your project would you like help with?
I feel like even for such a simple project my CSS ended up using way too many selectors and rules, so I'm only wondering if there was a cleaner, more concise way of doing it. Other than that, I have no specific questions.
Jvps321• 50@Jvps321
Posted
It was good, but when you mentioned the qr code, on line 20 you forgot to put the ".", leaving "/images/image-qr-code.png", there should be a period before "/images" like " . /images" In the beginning that was why the image didn't appear. Regarding HTML, it's fine. You could make it more semantic by replacing the qr-container div with the main tag, and if you wanted, you could leave the image in one div and the texts in another div. the css is good. I'm not very good, but if you want to look at my code to better see what I mentioned, my css ended up being a little big, as I was trying to make it as similar to what was proposed and as semantically as possible. link GitHub: https://github.com/Jvps321/landing-QR-code-component
Marked as helpful
0
