Design comparison
Solution retrospective
The thing I'm most proud of is having been able to use Git since I had no idea what it was and in the process of setting it up I thought I was gonna have to upgrade my laptop due to a lack of storage space, but I ultimately found I way I could use it without having to do any etreme changes to my setup.
What challenges did you encounter, and how did you overcome them?This is the firs challenge on the learning path and honestly I'm still not sure how this whole thing works. For example, the style guide stated thet I shoulde use a certain color for the background of the page, however, that specific shade of gray was much darker that the one shown in the example jpg provided, so I was unsure about wether or not I should have strictly stuck to the design guidelines or if I could take the freedom to do deviate from it in order to better match the example design. I ultimately ended up using an online color picker to better match the design example.
What specific areas of your project would you like help with?I feel like even for such a simple project my CSS ended up using way too many selectors and rules, so I'm only wondering if there was a cleaner, more concise way of doing it. Other than that, I have no specific questions.
Community feedback
- @Jvps321Posted 6 months ago
It was good, but when you mentioned the qr code, on line 20 you forgot to put the ".", leaving "/images/image-qr-code.png", there should be a period before "/images" like " . /images" In the beginning that was why the image didn't appear. Regarding HTML, it's fine. You could make it more semantic by replacing the qr-container div with the main tag, and if you wanted, you could leave the image in one div and the texts in another div. the css is good. I'm not very good, but if you want to look at my code to better see what I mentioned, my css ended up being a little big, as I was trying to make it as similar to what was proposed and as semantically as possible. link GitHub: https://github.com/Jvps321/landing-QR-code-component
Marked as helpful0@alvarozamaPosted 6 months ago@Jvps321
Thanks for pointing out my mistake in referencing the image's src. Very silly mistake, but I made it again on challenge 2, so this will help me on succesive ocassions. Also, I guess I agree on your code being much easier to read and semantically clear. Will take inspiration from that as well. Cheers.
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord