Design comparison
Community feedback
- @Jvps321Posted 6 months ago
It was good, but when you mentioned the qr code, on line 23 you forgot to put the ".", leaving "/images/image-qr-code.png", there should be a period before "/images" like " . /images" In the beginning that was why the image didn't appear. Regarding HTML, it's fine. You could make it more semantic by replacing the qr-container div with the main tag, and if you wanted, you could leave the image in one div and the texts in another div. the css is good. I'm not very good, but if you want to look at my code to better see what I mentioned, my css ended up being a little big, as I was trying to make it as similar to what was proposed and as semantically as possible. link GitHub: https://github.com/Jvps321/landing-QR-code-component
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord