Skip to content
OverviewSolutions
18
Comments
5
JanAbe
@JanAbe

All comments

  • JanAbe•230
    @JanAbePosted 10 months ago

    Nice work, it looks sick!

    One point of feedback though is that you use pixels to set the font-size.

    This is considered a bad practice because when a user increases his font-size in the browser, the text doesn't get larger 'cause it isn't responsive.

    Here is a blog post about it: https://fedmentor.dev/posts/font-size-px/

    Hope this helps

    Marked as helpful
    0
  • JanAbe•230
    @JanAbePosted 10 months ago

    Nice work!

    Feedback:

    It's a good idea to use landmarks in your html.

    You could for example use a <main> landmark to put in all your main content.

    https://developer.mozilla.org/en-US/blog/aria-accessibility-html-landmark-roles/#the_main_landmark

    It is also a good idea to use the <form> tag for forms instead of a div.

    Hope this helps

    0
  • JanAbe•230
    @JanAbePosted 10 months ago

    Looks sick and nice usage of landmarks in your html! The only thing is that the background-image doesn't take up all space on my screen. You can fix this using background-size: cover.

    0
  • JanAbe•230
    @JanAbePosted 10 months ago

    Nice solution but maybe you could add landmarks to your HTML.

    A header to contain the logo, a main to contain the content of the page, and a footer to contain the social links!

    Marked as helpful
    0
  • JanAbe•230
    @JanAbeSubmitted 10 months ago

    There is a clipping issue when the page is viewed on my phone. It looks good in the browser, even in the responsive tab of the browser. But the image gets cut off when viewed on mobile and the attribution text also gets placed incorrectly.

    I don't know how to fix this, does someone know?

    Help needed. Clipping issue on mobile. How to fix?

    1
    JanAbe•230
    @JanAbePosted 10 months ago

    Fixed the problem by changing height: 100svh to min-height:100svh. Thank you @AlexKMarshall over on discord for helping me !

    0