Design comparison
Solution retrospective
any suggestions appreciated
Community feedback
- @JanAbePosted 9 months ago
Nice work!
Feedback:
It's a good idea to use landmarks in your html.
You could for example use a
<main>
landmark to put in all your main content.https://developer.mozilla.org/en-US/blog/aria-accessibility-html-landmark-roles/#the_main_landmark
It is also a good idea to use the
<form>
tag for forms instead of a div.Hope this helps
0 - @lucasdaherPosted 9 months ago
Great job Belky!
I have a suggestion for you:
👀 In your
h1
theline-height
is bigger than design. To fix, use this on yourh1
:line-height: 55px;
Hope i helped!
Keep creating amazing projects!
0@belkysupreme22Posted 9 months ago@lucasdaher tnx for the comment, i will correct it accordingly
1@lucasdaherPosted 9 months ago@belkysupreme22 you're welcome! if you can, mark helpful on my feedback on your solution to help me :)!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord