any suggestions appreciated
@JanAbe
Posted
Nice work!
Feedback:
It's a good idea to use landmarks in your html.
You could for example use a <main> landmark to put in all your main content.
https://developer.mozilla.org/en-US/blog/aria-accessibility-html-landmark-roles/#the_main_landmark
It is also a good idea to use the <form> tag for forms instead of a div.
Hope this helps
@lucasdaher
Posted
Great job Belky!
I have a suggestion for you:
👀 In your h1 the line-height is bigger than design. To fix, use this on your h1:
line-height: 55px;
Hope i helped!
Keep creating amazing projects!
@belkysupreme22
Posted
@lucasdaher tnx for the comment, i will correct it accordingly
@lucasdaher
Posted
@belkysupreme22 you're welcome! if you can, mark helpful on my feedback on your solution to help me :)!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
