Skip to content
OverviewSolutions
24
Comments
18
Sankalpa Sarkar
@IllusiveCoder1101

All comments

  • Sankalpa Sarkar•520
    @IllusiveCoder1101Posted almost 2 years ago

    Firstly, congrats on completing the challenge . Now to answer your question whether you should keep the sass file or not. Answer:- Yes, Reason (If you remove the sass file, other people who view your code on Github, won't be able to know if you used sass or not).

    I noticed a few accessibility issues , to remove them use <main class='card' role='main'></main>, it should fix it. That's all :)

    Marked as helpful
    1
  • Sankalpa Sarkar•520
    @IllusiveCoder1101Posted almost 2 years ago

    Firstly congrats on completing the challenge , it wasn't an easy one. I noticed a few problems with your site:- 1.The step numbers present on the nav-bar/side-bar aren't meant to be buttons , their only purpose is to show the Active step. If treated as buttons , there would be no point of the next and the back buttons. 2. The site appears broken on my desktop, each of the sections are overflowing, so try testing it on all the screen provided on the console. 3.It's not dynamic , the site is clearly static, even when I choose a different plan , it's not updated on the confirmation page. 4.For the Accessibility error, try replacing the <h4/> tags with <h1/> tag. (Also there's a typo on the first page , you wrote "Pleas" ) That's mostly all :)

    0
  • Sankalpa Sarkar•520
    @IllusiveCoder1101Posted about 2 years ago

    You have to use the background-position property of the cuss to position those background images.

    0
  • Sankalpa Sarkar•520
    @IllusiveCoder1101Posted about 2 years ago

    For the inner divs of the card component you can use header for the first then the body tag and bottom part with the footer tag..

    0
  • Sankalpa Sarkar•520
    @IllusiveCoder1101Posted about 2 years ago

    The code looks great overall , to make the code even better you can try using semantic HTML tags like :- <header/> , <nav/> , <section/> etc. This would make your code more readable , rather than using so much divs. Otherwise you were spot on the final result looks great. Keep up the great work!!!!

    0
  • Daud Ismail Olakunle•20
    @EminentdioSubmitted about 2 years ago

    My problem in coding lies with rendering my webpage appropriately in mobile view. Is there anything I need to know specifically to solve that?

    I have always been having a kind of feeling of not having enough knowledge of any language before embarking on another one even if I can answer or practice any damn concept on it. Please is there a cure to this kind of syndrome?

    Please, don't forget to criticize this project as well. The last one helped me to improve on some things like designing for Screen Readers.

    Thanks!!

    Nft Preview Card Component

    3
    Sankalpa Sarkar•520
    @IllusiveCoder1101Posted about 2 years ago

    Congrats on completing the challenge, about the mobile display issue, I think you should look into css media queries which is responsible for display on different screen sizes. Keep up the great work!!!!

    Marked as helpful
    0
  • Sankalpa Sarkar•520
    @IllusiveCoder1101Posted about 2 years ago

    Congrats on completing the project , it was not quite an easy one. I found quite a few problems. First of all, I noticed in the planet, crew and tech page the buttons are not functional . I think you forgot to give them functionalities. Second of all about the logo , they provide starter files at the very beginning it contains all the assets in the images folder. Keep up the great work!!

    0
  • Sankalpa Sarkar•520
    @IllusiveCoder1101Posted about 2 years ago

    Congrats on completing the project it wasn't an easy job. I found two problems , One you forgot to add the second page(country info page) , second the dark mode doesn't cover the entire page . For the second problem you can try manipulating the main document class name to either dark mode or light mode depending on the time (also specify the colors for each dark mode and light mode ) and add it to the styles of the html tag. Otherwise great work!!

    Marked as helpful
    1
  • Sankalpa Sarkar•520
    @IllusiveCoder1101Posted about 2 years ago

    Congrats on completing the project , it was not an easy task. I would love to add just one thing whenever I search for Antarctica and click on the link the next page completely breaks, the reason behind why it's happening:- Antarctica has some missing data like border countries and capital, so place some conditions to check whether the data exists or not . Keep up the good work!!!

    Marked as helpful
    0
  • Sankalpa Sarkar•520
    @IllusiveCoder1101Posted about 2 years ago

    Congrats on completing the project. It looks great , just one thing you forgot to add the active states for the tech(last) page. Keep on making great projects like this , good luck!!

    1
  • Sankalpa Sarkar•520
    @IllusiveCoder1101Posted about 2 years ago

    First off congrats on completing the project , to get that effect you need to use keyframes to add animation at different points , For example:-

    @keyframes pop{ 0%{ transform: scale(1.1); } 33%{ transform: scale(1.3); } 66%{ transform: scale(1.2); } 100%{ transform: scale(1.1); } } This is a keyframe. you can reference the name of the animation on any element like this.

    .winner{ animation: pop; animation-duration: 2s; }

    You have to do something like this.

    0
  • Sankalpa Sarkar•520
    @IllusiveCoder1101Posted about 2 years ago

    First off congrats on completing the challenge. I found a small bug in your solution , on looking for the details for Antarctica the loading animation never stops. I think the cause of the problem is probably you forgot to place conditions on the data you are fetching. Place those conditions and it will get fixed.

    0