@huntdamannSubmitted 11 months ago
Any feedback on better ways to implement CSS Grid would be greatly appreciated
Hassan Arafa
@HassanArafa53All comments
- @HassanArafa53Posted 11 months ago
Great job on using grid system!, other than @kmr-mayumi's notes, it looks great but it would've been perfect if it was responsive on mobile, i'm guessing you haven't reached media queries yet..until then keep on doing great!
0 - @nmrtsnhSubmitted 12 months ago
Hello everyone,
I am Namrata and this is my solution for the News homepage challenge.
If you have any suggestions to improve my code, please feel free to share!
Thank you 🙏
@HassanArafa53Posted 12 months agoGreat job!, this is actually one of the few solutions that i really liked and enjoyed looking it, just to make it perfect!, please use Margin instead of Padding on the header element as Padding is not meant to be used like this, to understand it better please look it up or watch YouTube videos on it. if you try to make the page smaller and bigger with the browser you'll notice the nav-bar and links moving around because you've used Padding which is totally wrong in this case. one more thing give the 3 pictures in the bottom of the page max-height of 130px. Again great job keep going ❤️.. one more thing at 1206 pixels the page goes into mobile version but the hamburger menu doesn't show up.
1 - @vishnu-31Submitted 12 months ago
Hello, Everyone.
Completed the News Home Page challenge.
Used the GRID properties for the first time.
Had a great learning experience and it was fun.
Any suggestions are feedback will be helpful.
Thank you.
@HassanArafa53Posted 12 months agoPlus everything looks really huge from fonts to imgs in the end of the page.
1 - @vishnu-31Submitted 12 months ago
Hello, Everyone.
Completed the News Home Page challenge.
Used the GRID properties for the first time.
Had a great learning experience and it was fun.
Any suggestions are feedback will be helpful.
Thank you.
@HassanArafa53Posted 12 months agoas far as the mobile responsiveness it's great, but for the smaller screens it's not good I'm really sorry i'm not trying to put you down or make you feel bad. so let me explain this in the simplest way possible, whenever i try to put the page on a smaller screen and not on my 1920 x 1080 monitor , sidebar gets really big vertically and the header image just look oddly smaller, you need to work on the responsive side of small and big screens.
Marked as helpful1 - @LuispmvSubmitted 12 months ago@HassanArafa53Posted 12 months ago
Great job, but for better images, reset img preperty with this (display: block; & width: 100%), also give every image in the page a max-width of 100px and max-height of 130px
2
