News Page with CSS Grid

Community feedback

• 

  kmr-mayumi•10

  @kmr-mayumiPosted 11 months ago

  Hi @Hunter Mann! I'm a beginner too but I would like to give some observations that I noticed...

  1. Just for UX reasons, I would recommend using something like transition: .3s; in titles that are links;
  2. I noticed that you used the justify-content: center; and align-items:center; properties, but you didn't use the display: flex; in the body, which I believe was the goal to center all the content, but Because of this, he ended up using some tags like margin-top to try to centralize.

  Well, other than that I didn't notice anything much. In fact, as I'm not familiar with using display: grid;, with your solution I was able to learn more! Thank you very much :D

  1
• 

  Hassan Arafa•40

  @HassanArafa53Posted 11 months ago

  Great job on using grid system!, other than @kmr-mayumi's notes, it looks great but it would've been perfect if it was responsive on mobile, i'm guessing you haven't reached media queries yet..until then keep on doing great!

  0