@FridaWaldt
@AmiraxHamza
Submitted
The hardest part was not the code itself but actually submitting the project. This was my first time using Github as a contributor so I had to learn all the basics beforehand. But thankfully all the resources I needed were readily available.
@FridaWaldt
Posted
Hi Amirax!
Well done in completing and posting your challenge. π
I belive something went wrong with the github repository, I cloned your project and removed the 'p' in the name of your index.html file and it seemed to have fixed it. Would you try this solution and push it to github and hopefully we can see your solution. π
Let me know if it worked!
@eniskrt
Submitted
@FridaWaldt
Posted
Hi Enis! Well done on completing this challenge π
I have a suggestion to make it easier for you to center your card on the page, let me know if you try it out. π
In your CSS file, I suggest you add the following code to your body tag: height: 100vh
That way you can remove the margin-top: 10rem from your main.card tag.
Hope it helps, and good job! βοΈ
Marked as helpful
@Yabsira21
Submitted
@FridaWaldt
Posted
Hi Yabsira! Great job on completing this challenge. π
I looked through your code and well done on making it easily readable! I wanted to suggest a couple of things to you, let me know what you think. π
I see you left the alt attribute on the img tag empty, I would strongly recommend to fill this out, you can write for example "QR code: Frontend Mentor". Here's a nice article on the subject of Accessability! Accessability article
To center your card I would recommend removing margin: 0; in your CSS on the body tag, instead adding:
display: grid;
place-items: center;
height: 100vh;
You can also remove the following on the div tag and it would look centered:
margin: 0 auto;
position: relative;
top: 100px;
Good luck with your next challenge, you'll do great! π
Marked as helpful
@Egide20
Submitted
i honestly just started coding and i found alot of things difficult for example moving to div box to the center and making it smaller.
@FridaWaldt
Posted
Hi Egide! I wanted to help give you pointers by reviewing your code but couldn't get to your github repository, is it possible to make it public so that we can help you how to improve and help you with your difficulties of moving the div box to center? π
