Qr Code Card

Community feedback

• 

  P

  Øystein Håberg•10,550

  @Islandstone89Posted about 1 year ago

  Hi, well done, just a few suggestions.

  • The alt text should also tell where it leads.

  • I would get in the habit of doing a good CSS Reset at the beginning

  • height on body should be min-height.

  • Never set fixed widths, except for sometimes on icons. The content should determine the width and height.

  • width on img should be max-width.

  • You don't need to write main in front of the selectors :)

  Marked as helpful

  1

  ---

  

  Enis Kerti•590

  @eniskrtPosted about 1 year ago

  @Islandstone89

  Thanks your suggestions. Sice then I use some of you said. Nowadays I try to use % or ,as you said, min/max for my layouts. But I generally hesitate to use in my layout % or min/max. In your opinion, which one should I use?

  0

  

  P

  Øystein Håberg•10,550

  @Islandstone89Posted about 1 year ago

  @eniskrt You rarely need mins, and max only occasionally.

  1
• 

  Frida 🌼•90

  @FridaWaldtPosted about 1 year ago

  Hi Enis! Well done on completing this challenge 🙌

  I have a suggestion to make it easier for you to center your card on the page, let me know if you try it out. 😊

  In your CSS file, I suggest you add the following code to your body tag: height: 100vh

  That way you can remove the margin-top: 10rem from your main.card tag.

  Hope it helps, and good job! ✔️

  Marked as helpful

  1

  ---

  

  Enis Kerti•590

  @eniskrtPosted about 1 year ago

  @FridaWaldt Tanks for your suggestion. Immediately i apply your suggests. i'm on way.😊

  1

  

  Enis Kerti•590

  @eniskrtPosted about 1 year ago

  it works😊 @FridaWaldt

  0

  

  Frida 🌼•90

  @FridaWaldtPosted about 1 year ago

  @eniskrt Happy to hear this Enis! Good job! 😊

  0
• 

  Enis Kerti•590

  @eniskrtPosted about 1 year ago

  Its funny to do this. As far as I do I try to use semantic html tags. I add all card in a main tag. Its accessible to eveyone. I didn't improve my responsive display. But i think generall looks good in every size.

  0