QR code component

Community feedback

• 

  Frida 🌼•90

  @FridaWaldtPosted about 1 year ago

  Hi Yabsira! Great job on completing this challenge. 🎉

  I looked through your code and well done on making it easily readable! I wanted to suggest a couple of things to you, let me know what you think. 😊

  I see you left the alt attribute on the img tag empty, I would strongly recommend to fill this out, you can write for example "QR code: Frontend Mentor". Here's a nice article on the subject of Accessability! Accessability article

  To center your card I would recommend removing margin: 0; in your CSS on the body tag, instead adding:

  display: grid;
  place-items: center;
  height: 100vh;
  

  You can also remove the following on the div tag and it would look centered:

  margin: 0 auto;
  position: relative;
  top: 100px;
  

  Good luck with your next challenge, you'll do great! 🎇

  Marked as helpful

  1

  ---

  

  Yabsira•710

  @Yabsira21Posted about 1 year ago

  @FridaWaldt Thanks for the feedback

  0