@Garab02Submitted 5 months ago
FranciscoDavidCampuzanoMelgarejo
@FranciscoDavidCampuzanoMelgarejoAll comments
- @FranciscoDavidCampuzanoMelgarejoPosted 2 months ago
Your solution doesn't fit the given design too well. Right now I can't review your code completely (I think you have quite a few errors and missing things). But if you want I can clone your repository and take a look at it tonight (European time) and tell you the errors you have and correct several things.
0 - @MR-GaidSubmitted 3 months ago@FranciscoDavidCampuzanoMelgarejoPosted 3 months ago
Things that could be improved:
-
I think you follow a desktop design approach, I suggest you start with the mobile version first (easier). When doing the HTML you focus on both and even more on the desktop design, but when you start with the CSS I suggest that you first focus on the mobile design.
-
The triangle below the social networks in the desktop layout can be made using pseudo-elements (maybe it's more comfortable) and the transition when clicking the button is a bit strange.
-
I also recommend using variables in CSS (custom properties)
-
The rest of the things are pretty good, maybe you can adjust more to the given design (in terms of padding and that stuff)
Keep it up!
Marked as helpful0 -
- @logic23devSubmitted 5 months ago@FranciscoDavidCampuzanoMelgarejoPosted 3 months ago
Your solution is very good. It is practically identical to the design. The only thing I can tell you is that using grid-template-areas is more direct and easier to do. So I encourage you to try using areas. Keep it up!
0 - @igormqnSubmitted 5 months ago@FranciscoDavidCampuzanoMelgarejoPosted 3 months ago
Things I don't like very much or things that are missing:
- Fixed card size (I don't like it very much)
- Font size and weight are incorrect (it's still fine)
- The shadows are very thick
- The order of cards is incorrect in the desktop layout
Things I like:
- Good HTML design (simple and straightforward)
- Clear and very understandable CSS at a glance
Keep it up!
0 - P@astnioSubmitted 7 months ago@FranciscoDavidCampuzanoMelgarejoPosted 7 months ago
It's pretty good. Good use of HTML semantic tags and well organized. Here is a YouTube video from Kevin Powell about this same problem. It will be more helpful to you.
https://www.youtube.com/watch?v=B2WL6KkqhLQ&t=2209s
0 - @ravikant717Submitted 7 months ago@FranciscoDavidCampuzanoMelgarejoPosted 7 months ago
Good job. The only bad thing I see is that you are not using the appropriate colors and font weights. For desktop, the right margin is larger than the left (remember to use margin: auto). It gives me the feeling that everything is very close together (improve spacing). The spacing within the table is not all that good.
0 - @AamnbabaSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of to complete this project 3x faster than my previous 2 projects. I didn't face any problem coding layout and responsive model. It gave me much confidence.
What challenges did you encounter, and how did you overcome them?In absence of Figma Design file, it was tough for me to adjust the sizes of my containers.
What specific areas of your project would you like help with?I would like to have help about the more layout models like grid.
@FranciscoDavidCampuzanoMelgarejoPosted 7 months agoPretty good. But, just like you used 'gap' on the container, you could have used 'gap' on the <div> of the personal information (more direct than using margin) and you could have done the same with the link list, that way the last element does not add margin.
Overall, all good
0 - @phtm-haruSubmitted 8 months ago@FranciscoDavidCampuzanoMelgarejoPosted 8 months ago
Pretty solid. Although you could use fewer lines of code, but overall pretty good. Keep it up
1 - @Hamza-MusaSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
got the basics down
@FranciscoDavidCampuzanoMelgarejoPosted 8 months agoThe html code is not finished and, practically you did not add CSS code to style your page. Try at least put all the content inside a container and center it inside the <body> tag.
0
