NaQu• 570
@NaQu2003
Submitted
Any feedback of how i can improve are highly welcome
Fayozxon
@Fayozxon
All comments
- Fayozxon• 530
@Fayozxon
Posted
Hello my friend
I see that the description text on the hero section is two lines on the design, but your is one line and really makes it difficult and uncomfortable to read.
To solve this problem I suggest you to use the css
max-widthproperty. It does not let the element exceed the given width limit.For example if you set
max-width: 500pxthe maximum width the text can reach is 500px, in this way you can easily solve the problem.Good luck with the future projects!
Marked as helpful
0 - Abubakar Tanko• 290
@Abubakar-Tanko
Submitted
Feedbacks are welcomed and if there is any thing that needs correction please feel free to tell. Thank you in advance 🙂
Fayozxon• 530@Fayozxon
Posted
Hello Abubakar Tanko.
When I looked at your code I noticed that you used id's in css and I don't think it is best practice. I would suggest you to use id's only for javascript and classes for css.
Good luck in your future projects.
Marked as helpful
0 - Fayozxon• 530
@Fayozxon
Posted
Just a quick reminder: the favicon is still vite logo, i would recommend chaning it.
0 - Muhammadjavohir• 280
@Muhammadjewel
Submitted
Challenge #9 is completed 🎉
Thanks to Grace Snow I changed my approach to responsive design. Changed px to em and rem when applicable.
Also, I used a bit different style of naming/structuring custom properties.
Any constructive feedback is welcome.
Fayozxon• 530@Fayozxon
Posted
For naming variables you can use Kevin Powell's method.
Instead of
--color-primary-bg, you should write repeatitive words first, (also suggest short forms) like--clr-bg-primaryor--clr-txt-secondaryI would also suggest you to use variables not just for colors or shadows but also font sizes.
Marked as helpful
2 - Rino• 340
@Rhinozer0s
Submitted
My first Project on Frontend-Mentor. Would like it to get some feedback :)
Fayozxon• 530@Fayozxon
Posted
Hello, Rhinozer0s. Congratulations on your first project! It is great but you should adjust the size of the cards (maybe by giving some padding) and the shadow (in the design it looks softer) and also, you I suggest you using semantic elements on HTML like h3 instead of span or div for a text. Good luck on your next project!
2 - Shaxboz• 1,230
@shakhboz-shukhrat
Submitted
Hello everyone! I have just completed this project! It was very fun to build and there are many issues but it is working just fine.
I wanted to suggest a group project if anyone is interested. I would like to do advanced level project with a team. I think that it would be very not only interesting but also helpful.
Fayozxon• 530@Fayozxon
Posted
I was also doing this project (although i don't have acces to this challenge, i copied from preview) and I am using VueJS and Bootstrap, Sass. You can find the site preview and source code on telegram: @fayozhons
0 - Shaxboz• 1,230
@shakhboz-shukhrat
Submitted
Fayozxon• 530@Fayozxon
Posted
Hi Shaxboz! I have a few suggestion for this project:
- you should use semantic HTML elements like <section> or <header>
- the website has a horizontal scroll which should be avoided
- it must be adaptive to various devices
- whole website is left-aligned, not center You should probably check the code and consider rebuilding Good luck
Marked as helpful
0 - Shaxboz• 1,230
@shakhboz-shukhrat
Submitted
Hello !!! It was easy and fun to build! Hope you guys will find this challenge as much easy as I did
Good luck!
Fayozxon• 530@Fayozxon
Posted
Hi Shaxboz, I think you should make the shadow softer as in original design, because it looks a bit unprofessional. Good luck
1 - Eboreime Ohiole Ojo• 290
@Ohiole
Submitted
I found the responsiveness tasking, but i did not have to define @media queries to make it responsive
Fayozxon• 530@Fayozxon
Posted
Hi Ohiole! I suggest you to make the shadow softer as in original design. Good luck!
0
