Design comparison
SolutionDesign
Solution retrospective
Challenge #9 is completed 🎉
Thanks to Grace Snow I changed my approach to responsive design. Changed px to em and rem when applicable.
Also, I used a bit different style of naming/structuring custom properties.
Any constructive feedback is welcome.
Community feedback
- @FayozxonPosted about 1 year ago
For naming variables you can use Kevin Powell's method.
Instead of
--color-primary-bg
, you should write repeatitive words first, (also suggest short forms) like--clr-bg-primary
or--clr-txt-secondary
I would also suggest you to use variables not just for colors or shadows but also font sizes.
Marked as helpful2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord