First Frontend Mentor Project

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution lacks semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So fix it by replacing the <div class="wrapper"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body element instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Eboreime Ohiole Ojo•290

  @OhiolePosted over 1 year ago

  Thank you very much, this was very helpful @0xAbdulKhalid

  0
• 

  Fayozxon•530

  @FayozxonPosted over 1 year ago

  Hi Ohiole! I suggest you to make the shadow softer as in original design. Good luck!

  0

  ---

  

  Eboreime Ohiole Ojo•290

  @OhiolePosted over 1 year ago

  Thank you, done that with the new code @Fayozxon

  0