@Al3sshuSubmitted 3 days ago
P
Facundo Andrés De Los Rios
@FacundoDLRAll comments
- @FacundoDLRPosted 3 days ago
Wow, I really liked the result of your code, especially the animation for the click event on the share button. The responsiveness also looked great and reacts well to screen changes, I'll look at your code in more detail to learn a little more heh. I just finished this challenge and I need to add animations and resonsive like your project, I hope to continue learning 😊.
0 - @EKriley-ciSubmitted 19 days agoWhat are you most proud of, and what would you do differently next time?
je suis fier de la manier dont je suis arriver sans trop de difficulté a maitriser le responsive design pour différents appareils cependant je sais que mon code est très loin d'être parfait du coup je vais a l'avenir me concentrer plus sur comment écrire moins de code et plus clairement aussi pour les autres qui analyserons mon code
What challenges did you encounter, and how did you overcome them?je n'ai pas vraiment rencontrer de grand de défis insurmontables mais cependant je suis ouverte au conseil si vous pouvez me dire comment je peux ameliorer mon code et aussi ou j'aurai du utiliser des raccourci utile
What specific areas of your project would you like help with?je sais pas vraiment ce qui ce passe avec mon github mais il ne charge pas certaines images de ce projet , j'essais mais rien ne change il ne veut pas charger l'image du footer alors j'ai ajouter une couleur pour compenser mais si quelqu'un a déja rencontré ce probleme qu'il m'aide
@FacundoDLRPosted 5 days agogood job, I could suggest that you add the image with transparency in the footer. Otherwise very faithful to the original design.
0 - @gurpal-devSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I'm happy that I'm able to use
What challenges did you encounter, and how did you overcome them?display: grid;in this project. Next time, I will do deep analysis of the project, try to visualize where everything could be placed, before jumping in directly to write code.The positioning of components inside the grid areas. I got so confused. I took help from Kevin Powell's video on the display grid. It helped me in learning many things related to display grid. I will highly recommend you to watch it if you're looking for learning display grid.
What specific areas of your project would you like help with?I want a feedback on HTML semantics and on CSS in general. I want to know how others set the body to achieve the position of elements in center. I want to know why when I use
body{ height: 100%; }doesn't add the padding at the bottom when it is given (to give space on the top and bottom as it is given in the design), but when the padding is given at the top, it adds to the top without any problem.However, when I use
body { min-height: 100%/vh; }. It does add padding to the top and bottom without a problem.@FacundoDLRPosted 9 days agonice work!! I just only can say what you can add some properties for center the testimonials cards using flex properties or grid, just adding into the body tag since is the main container.
display:flex; justify-content:center; align-items: center; /* or grid */ display: grid; place-content: center;I hope my comments are helpful to you. Happy coding =)
0 - @BoffdubSubmitted 11 days agoWhat are you most proud of, and what would you do differently next time?
It was a struggle at first because I was just trying to figure out flexbox but it wasn't working the way I wanted to. But I was proud I stuck with it and eventually figured it out.
What challenges did you encounter, and how did you overcome them?See above.
What specific areas of your project would you like help with?Just if there is any glaring mistakes I made.
@FacundoDLRPosted 11 days agoHello, I was looking at your solution and I could suggest that you try the grid design system for the cards section, I think it could be much better for you (I used it in this same challenge and the result is fantastic). Also, you can take a look at the responsive design, apparently it doesn't work well on different screens and finally you could change the color of the card titles to the same one you used in the .intro h1 class (it will look much better visually).
I hope my comments are helpful to you. Happy coding =)
1 - @ramram14Submitted 14 days ago@FacundoDLRPosted 14 days ago
The design looks good, responsive. I could suggest some changes to improve the appearance:
- add CSS property align-items: center; in class .price
- in the .sml-text class you could change the font to "Montserrat"
- and finally you could try to make the image of the shopping cart look a little smaller since it takes all the attention and it is not the idea.
These are my small contributions, I hope they help you. happy coding 😊
Marked as helpful1 - @artemkotko14Submitted 28 days agoWhat are you most proud of, and what would you do differently next time?
I am proud of responsive design of this webpage.
@FacundoDLRPosted 24 days agoHi! I have seen your solution and the result is fantastic, maybe I can suggest you add some margin at the top and bottom. And I looked at the measurement relationship that you used for the body of your html, I don't know a "svh" measurement and I don't really know how it works and how much support it has in browsers. For the rest everything is very good. Greetings =)
0 - @Iago-MarquesSubmitted 8 months ago@FacundoDLRPosted about 1 month ago
@lago-Marques, I really like your solution to the challenge, it is very faithful to the original. Your HTML document is super well structured and the fact that you used the <nav> tag for the social media buttons is very well used, it had not occurred to me. You could improve perhaps by adding meta tags to the HTML to improve SEO and in case you want to share your link on social networks.
Greetings! =)
Marked as helpful1 - @artemkotko14Submitted about 1 month agoWhat are you most proud of, and what would you do differently next time?
I am proud of implementing hover states and focus states in this project.
@FacundoDLRPosted about 1 month agoHi @artemkotko14!
wow, your solution to the challenge looks very professional, I was looking at the demo and code and I don't have much to comment, everything is very clean and clear. keep it up 🦾
Marked as helpful0 - @bmch09Submitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
to do it
What challenges did you encounter, and how did you overcome them?practise everyday
What specific areas of your project would you like help with?everything
@FacundoDLRPosted about 1 month agoHi @bmch09
I reviewed your solution and saw that you created a landing page that looks great on the indicated PC and Mobile formats. It matches the images of the design, but I would suggest that you look at the free figma design that complements the challenge, there you can find valuable information to achieve a more polished result. You can also improve this by using the browser's element inspection tool to test different dimensions and CSS styles.
I hope it helps you! =)
Have a nice coding!
Marked as helpful0
