All comments

• 

  Marcos Travaglini• 4,920

  @Blackpachamame

  Submitted 7 months ago

  What are you most proud of, and what would you do differently next time?

  Construido con:

  • HTML5
  • CSS3
  • JavaScript
  • Flexbox
  • Grid CSS
  • BEM

  Lo que aprendí: Este desafío lo use para repasar y practicar lo aprendido.

  

  Age calculator app

  1

  110

  

  Enver• 80

  @EnverUsta

  Posted 5 months ago

  Congratulations for the project, I really liked it.

  I noticed that you forgot using clearTime() function. When, I recalculate the value it actually doesn't destroy the previous setTimeout. I think because of that when I put 100 or something into the year input, then before it calculates the value(as you know it takes long), it starts to another calculation and it causes an issue in the project.

  I just wanted to let you know, have a good day!

  Marked as helpful

  1
• 

  ivan parra• 750

  @ivanparraoda

  Submitted 8 months ago

  "Any advice to improve my code is always welcome."

  

  Social links profile

  1

  40

  

  Enver• 80

  @EnverUsta

  Posted 8 months ago

  Hi @ivanparraoda, congratulations for the solution. I have a few advice for you.

  📌 You can improve your html semantic. Instead of using div directly inside of your body, you can use main.

  📌 It seems like the usage of header specific to the card doesn't make sense in your context. Use header for the whole page if it's necessary not for your card. html-semantic

  📌 Comments like /* Center horizontally */ doesn't make sense, your code already explains what it's doing. Using unnecessary comments reduce the readability.

  📌 class="container" is a generic name, instead use something like profile-card.

  📌 Leverage the usage of classes not ids. id="city"

  📌 Don't use generic selectors like h2, p. Maybe you can use something like .profile-card h2 {...}. If you use them as generic when the project complexity increases, it will be hard to come up with a solution.

  0
• 

  Abdelrahman Mohamed Mohamed Ahmed• 190

  @abdelrahman-mohammed1

  Submitted 8 months ago

  What are you most proud of, and what would you do differently next time?

  Building Social links profile using html and css

  What challenges did you encounter, and how did you overcome them?

  make a component reusable as possible

  What specific areas of your project would you like help with?

  html for structure css for style

  

  Soical Link Card

  1

  70

  

  Enver• 80

  @EnverUsta

  Posted 8 months ago

  Hi @abdelrahman-mohammed1, Congratulations for the solution 😎

  I would like to give you a quick feedback, I hope it will help you 👊

  1. In your .container class text-align seems useless since you already used justify-content: center. Using text-align in a parent component is a bad-practice.
  2. Using white space after each colon make your code more readable.
  3. Please add blank line after each selector.
  4. It also seems like you are using exact pixel values. I think using rem would make it better.

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  SpeedyRicky• 60

  @SpeedyRicky

  Submitted 8 months ago

  hello I am here

  

  QR code

  2

  50

  

  Enver• 80

  @EnverUsta

  Posted 8 months ago

  Hey @SpeedyRicky, congratulations for your first project here!

  I have a few suggestions for you:

  1. Don't use p, img or h2 as selector, instead use classes. It might not mean so much thing in this kind of relatively small projects, however, it will good for the future projects.
  2. Instead of using exact pixel values, you can use rem. Also you can leverage the usage of max-width instead of just width in some places.
  3. I have noticed that you repeated font-family: 'Outfit', sans-serif; twice. You can declare this statement in a more generic way and avoid duplication.

  0
• 

  P

  dss502598• 10

  @dss502598

  Submitted 8 months ago

  

  QR code component solution using vanilla CCS

  1

  50

  

  Enver• 80

  @EnverUsta

  Posted 8 months ago

  Congratulations! Your solution appears really good 👊. However, I have a few suggestions for you:

  • I noticed that you wrote the same font-family: 'Outfit', sans-serif; twice. I think you can use it in a more generic way and avoid the code duplication.
  • It seems like you have used exact pixel values in a few places (like this: width: 320px; height: 497px;). Maybe you might use more responsive-friendly units.

  Marked as helpful

  1