Construido con:
Lo que aprendí: Este desafío lo use para repasar y practicar lo aprendido.
Congratulations for the project, I really liked it.
I noticed that you forgot using clearTime() function. When, I recalculate the value it actually doesn't destroy the previous setTimeout. I think because of that when I put 100 or something into the year input, then before it calculates the value(as you know it takes long), it starts to another calculation and it causes an issue in the project.
I just wanted to let you know, have a good day!
"Any advice to improve my code is always welcome."
Hi @ivanparraoda, congratulations for the solution. I have a few advice for you.
📌 You can improve your html semantic. Instead of using div directly inside of your body, you can use main.
📌 It seems like the usage of header specific to the card doesn't make sense in your context. Use header for the whole page if it's necessary not for your card. html-semantic
📌 Comments like /* Center horizontally */ doesn't make sense, your code already explains what it's doing. Using unnecessary comments reduce the readability.
📌 class="container" is a generic name, instead use something like profile-card.
📌 Leverage the usage of classes not ids. id="city"
📌 Don't use generic selectors like h2, p. Maybe you can use something like .profile-card h2 {...}. If you use them as generic when the project complexity increases, it will be hard to come up with a solution.
Building Social links profile using html and css
What challenges did you encounter, and how did you overcome them?make a component reusable as possible
What specific areas of your project would you like help with?html for structure css for style
Hi @abdelrahman-mohammed1, Congratulations for the solution 😎
I would like to give you a quick feedback, I hope it will help you 👊
.container class text-align seems useless since you already used justify-content: center. Using text-align in a parent component is a bad-practice.hello I am here
Hey @SpeedyRicky, congratulations for your first project here!
I have a few suggestions for you:
p, img or h2 as selector, instead use classes. It might not mean so much thing in this kind of relatively small projects, however, it will good for the future projects.font-family: 'Outfit', sans-serif; twice. You can declare this statement in a more generic way and avoid duplication.Congratulations! Your solution appears really good 👊. However, I have a few suggestions for you:
font-family: 'Outfit', sans-serif; twice. I think you can use it in a more generic way and avoid the code duplication.width: 320px; height: 497px;). Maybe you might use more responsive-friendly units.