QR code

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 10 months ago

  Hello @SpeedyRicky!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, use <h1> for the main title instead of <h2>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  • Second: Still about semantic HTML, use <main> to wrap the main content instead of <div>.

  All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  1
• 

  Enver•80

  @EnverUstaPosted 10 months ago

  Hey @SpeedyRicky, congratulations for your first project here!

  I have a few suggestions for you:

  1. Don't use p, img or h2 as selector, instead use classes. It might not mean so much thing in this kind of relatively small projects, however, it will good for the future projects.
  2. Instead of using exact pixel values, you can use rem. Also you can leverage the usage of max-width instead of just width in some places.
  3. I have noticed that you repeated font-family: 'Outfit', sans-serif; twice. You can declare this statement in a more generic way and avoid duplication.

  0