@EnverUsta
Posted
Hi @ivanparraoda, congratulations for the solution. I have a few advice for you.
š You can improve your html semantic. Instead of using div
directly inside of your body
, you can use main
.
š It seems like the usage of header
specific to the card doesn't make sense in your context. Use header
for the whole page if it's necessary not for your card. html-semantic
š Comments like /* Center horizontally */
doesn't make sense, your code already explains what it's doing. Using unnecessary comments reduce the readability.
š class="container"
is a generic name, instead use something like profile-card
.
š Leverage the usage of classes not ids. id="city"
š Don't use generic selectors like h2
, p
. Maybe you can use something like .profile-card h2 {...}
. If you use them as generic when the project complexity increases, it will be hard to come up with a solution.