Social links profile

Community feedback

• 

  Enver•80

  @EnverUstaPosted 10 months ago

  Hi @ivanparraoda, congratulations for the solution. I have a few advice for you.

  📌 You can improve your html semantic. Instead of using div directly inside of your body, you can use main.

  📌 It seems like the usage of header specific to the card doesn't make sense in your context. Use header for the whole page if it's necessary not for your card. html-semantic

  📌 Comments like /* Center horizontally */ doesn't make sense, your code already explains what it's doing. Using unnecessary comments reduce the readability.

  📌 class="container" is a generic name, instead use something like profile-card.

  📌 Leverage the usage of classes not ids. id="city"

  📌 Don't use generic selectors like h2, p. Maybe you can use something like .profile-card h2 {...}. If you use them as generic when the project complexity increases, it will be hard to come up with a solution.

  0