Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social links profile

ivan parraā€¢ 750

@ivanparraoda

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


"Any advice to improve my code is always welcome."

Community feedback

Enverā€¢ 80

@EnverUsta

Posted

Hi @ivanparraoda, congratulations for the solution. I have a few advice for you.

šŸ“Œ You can improve your html semantic. Instead of using div directly inside of your body, you can use main.

šŸ“Œ It seems like the usage of header specific to the card doesn't make sense in your context. Use header for the whole page if it's necessary not for your card. html-semantic

šŸ“Œ Comments like /* Center horizontally */ doesn't make sense, your code already explains what it's doing. Using unnecessary comments reduce the readability.

šŸ“Œ class="container" is a generic name, instead use something like profile-card.

šŸ“Œ Leverage the usage of classes not ids. id="city"

šŸ“Œ Don't use generic selectors like h2, p. Maybe you can use something like .profile-card h2 {...}. If you use them as generic when the project complexity increases, it will be hard to come up with a solution.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord