@dazzlerabhi30800
Submitted
Hoping for a nice feedback about the layout there are some issues!!
@Ehtish
@dazzlerabhi30800
Submitted
Hoping for a nice feedback about the layout there are some issues!!
@Ehtish
Posted
Hello @dazzlerabhi30800, Congratulations on completing challenge. I have analyze your code. Add the Following code to improve your layout.
.navbar {
padding block:2rem;
/*Note: Remove your navbar padding */
}
/*Add your gray curve image */
.header--wrapper{
background-image: url(images/bg-curve-desktop.svg);
background-repeat: no-repeat;
background-position: bottom center;
}
@eerolli
Submitted
My first attempt at using media queries. Could I have done this without them? Any other feedback welcome.
@Ehtish
Posted
Hello Eero, Congratulations on completing challenge. You have done a great job with media query.
Few suggestions if you don't mind:
html{ font-size: 62.5%; }
/* For mobile */
@media(min-width: 480px){
html{
font-size: 55%;
}
}
best of luck
@Zajaczkowski23
Submitted
My first time working with API. All feedbacks are welcome
@Ehtish
Posted
You have done a great work. If you don't mind, I want to add some value regarding your github repository. I have analyzed your github repository. I highly recommend you to add read.me file in the project repository. In this way you showcase your project on github easily.
@jlmunozfdev
Submitted
I'm still having problems with the component overflow part when shrinking the screen. Even if you apply responsive layouts to elements, there are sizes where some components overflow. If someone could advise me on how I could improve I would be delighted.
@Ehtish
Posted
After analyzing your code.
"Important Suggestion and code for you"
** Write your responsive.css (media query) code in the end of style.css file & remove extra file responsive.css ...? why?? see in point 2 **
In style.css.
Remove
flex direction:column;
in .section__container class
Save your time (Follow DRY principle):
.section__container {
flex-direction: row;
/* there is no need to write
display:flex;
and
other extra codes because we already
write above....(style.css)
As a result
- save time
- improve code quality
- fast development */
}
}
Marked as helpful