Skip to content
OverviewSolutions
11
Comments
7
Edgar Badillo
@EdgarBadillo

All comments

  • Robert Iancu•-20
    @R0b3rtGSubmitted about 3 years ago

    I tried this challenge and I think it turned out pretty good.

    It might not be the best but I'm happy with the result.

    What do you think? Please leave some feedback!

    CSS basics, HTML, Flexbox, Grid

    4
    Edgar Badillo•215
    @EdgarBadilloPosted about 3 years ago

    You can use 2 background on the same times. Look this documentation https://css-tricks.com/css-basics-using-multiple-backgrounds/

    0
  • Edgar Badillo•215
    @EdgarBadilloPosted over 3 years ago

    Hello nice day.

    You did a good job.

    Some suggestion on this challenger:

    --Try to use less gap between your btn and your p.

    -- on desktop resolution, your images are no alined on y axis.

    Keep training .

    Marked as helpful
    1
  • Valerio•30
    @ValerioP-developerSubmitted over 3 years ago

    Each good tip for improving is well accepted. Thank you in advance.

    HTML-CSS-bootstrap

    2
    Edgar Badillo•215
    @EdgarBadilloPosted over 3 years ago

    If this your first proyect, i suggest to use pure css and html first, because your Class: are very very large, and hard to read. If you are trying to improve you bootstrap skills, is good.

    Nice job.

    0
  • Yuko-code•235
    @Yuko-codeSubmitted over 3 years ago

    This is my 8th FM challenge. I couldn't display the number thing (the ones in circles with vertical line on top) at the bottom properly.

    Meet Landing Page

    3
    Edgar Badillo•215
    @EdgarBadilloPosted over 3 years ago

    Hello nice day.

    I did this challenger 2 weeks ago and you have same mistakes as me.

    --- you have a side scroll (x axis) in all your resolution (mobile, pad, and desktop) is not a big deal but you can resolve this looking for you element wider than others. I found it and is your .header-img. your img has 414px width and your body has 360 px. fix you image and the side scroll will dissapear.

    --i use a main container for all my code (.container) is better that only body.

    -- on .number. maybe you can change to relative to fix you .one. --your div footer, you can use a z--index .9999 to overplace you .div one. because circle is still visible.

    --my mian problem on this challenger was classes name. Try to use a BEM methodology on your next challenges. Is not necesary but will helpyou to have a excelent organization on your classes names.

    Soryy for my english, have a nice day.

    Marked as helpful
    0
  • Youssef Ali•35
    @youssefali715Submitted over 3 years ago

    This is my first challenge on frontendmentor.io. I have made it with pure HTML & CSS only. Please give me your feedback to help me to improve myself and become a better programmer.

    3-column preview card component Solution

    3
    Edgar Badillo•215
    @EdgarBadilloPosted over 3 years ago

    Nice jobs.

    My (personals) advice:

    -- Try to use only flexbox on this exercise, because, on ipad resolution, you 3 cards do not fit on your container. (resolution 768 x 1024 px).

    --If you are using <div class="container"> you dont need this div. <div class="parent"> is not a big change but you will use less line.

    --resently, i have been using BEM methodology (BEM — Block Element Modifier is a methodology that helps you to create reusable components and code sharing in front-end development). some people like it another one no, but in my experience this helpme to organice better my classes on css.

    Keep training. Sorry for my english.

    Marked as helpful
    1
  • Edgar Badillo•215
    @EdgarBadilloPosted over 3 years ago

    Hola gabriel. In resolution 894 x 814, your container does not has enought space to handle your div class="texts" Because your container has a height : 90% container { width: 75%; height: 90%; background-color: var(--cards-background-color); border-radius: 10px; display: flex; flex-direction: column;

    Try to use a 100% height and that will fix your responsive problem. Use some pading botton to separe.

    Sorry for my english.

    Have a nice day

    0
  • Edgar Badillo•215
    @EdgarBadilloPosted over 3 years ago

    Hi.

    check responsive design in mobile screens.

    Try to use background image: url() on a div to get a responsive image.

    Sorry for my english.

    Send me a message if you need help :D

    Marked as helpful
    0